On 2026/07/07 21:07, Raphael Graf wrote:
> On Fri, Jun 26, 2026 at 05:35:37PM +0200, Rafael Sadowski wrote:
> > On Fri Jun 26, 2026 at 12:36:29PM +0200, Raphael Graf wrote:
> > > The attached diff updates hydrogen to the latest version 1.2.6.
> > > Instead of updating the numerous patches and files for the sndio-backend,
> > > I have enabled portaudio and portmidi. This makes updating the port a lot
> > > easier. There are only a few patches left, some of them have already been
> > > upstreamed.
> > > 
> > > Comments, test or OKs are welcome.
> > > 
> > 
> > Diff reads fine, package, run and don't crash. I'm glad we've sorted out
> > another Qt5 port.
> > 
> > I've no opinion on removing the sndio backend.
> > 
> 
> If we want to keep the sndio backend, I think it should be upstreamed, as
> maintaining so many patches is really impractical. I have no time to do that
> at the moment though. 
> 
> Does anyone else has an opinion on this?

It would be sad to lose existing sndio support for music _production_
software. Maybe sound out upstream about whether they'd accept a PR
adding it, if so then it's probably worth doing that, if not then
drop it?

> > > +V=			1.2.6
> > > +DISTNAME=		hydrogen-${V}
> > >  SITES=			${SITE_SOURCEFORGE:=hydrogen/}

looks like github is really the main site now, so might be better to
list that instead (distfile is the same on both there and sourceforge,
so I think they will have downloaded from gh and uploaded to sf).

> > > +DISTFILES.doc=		${V}.tar.gz
> > > +SITES.doc=		https://github.com/hydrogen-music/documentation/archive/refs/tags/
...
> > >  post-install:
> > > -	cp -rp ${WRKSRC}/data/doc ${PREFIX}/share/doc/hydrogen
> > > +	${INSTALL_DATA_DIR} ${PREFIX}/share/doc/hydrogen
> > > +	cp -rp ${WRKDIR}/documentation-${V}/* ${PREFIX}/share/doc/hydrogen/
...
> > > +SHA256 (1.2.6.tar.gz) = N1zn1GCosz5FEEIzDv9Ezv//0K0iDVCyxJsFfSsBKX8=
> > > +SHA256 (hydrogen-1.2.6.tar.gz) = 77oyYQSYrN52+i4UcBfJGyDBPslF4F40jNQYP9FhO+E=
> > > +SIZE (1.2.6.tar.gz) = 41540294
> > > +SIZE (hydrogen-1.2.6.tar.gz) = 14412178

1.2.6.tar.gz is not really a valid tar name in distfiles. how about this?

---
DIST_TUPLE = github hydrogen-music documentation 1.2.6 ${WRKDIR}/documentation

post-install:
	cp -r ${WRKDIR}/documentation ${PREFIX}/share/doc/hydrogen
---