Index | Thread | Search

From:
Lydia Sobot <chilledfrogs@disroot.org>
Subject:
Re: New port: www/chawan
To:
yaydn@protonmail.com
Cc:
ports@openbsd.org
Date:
Thu, 06 Aug 2026 10:30:30 +0200

Download raw body.

Thread
On August 6, 2026 10:24:42 GMT+02:00, yaydn@protonmail.com wrote:
>> >Also while no spaces where tabs are preferred, but the lines are not
>> >very symmetrical? Staggered rather than consistent. Not big.
>> >Possible change below.
>> >
>> >ONLY_FOR_ARCHS =	amd64 arm64 i386 # Nim arches
>> >
>> >COMMENT =	TUI web/Gopher/Gemini/SFTP browser with CSS and JS support
>> >DIST_TUPLE +=	srht bptato chawan v$V .
>> >V =		0.4.3
>> >
>> >CATEGORIES =	www sysutils
>> >HOMEPAGE =	https://chawan.net/
>> >
>> >MAINTAINER =	Lydia Sobot <chilledfrogs@disroot.org>
>> >
>> ># Public Domain/Unlicense,
>> ># see https://git.sr.ht/~bptato/chawan/tree/HEAD/res/license.md for deps
>> >PERMIT_PACKAGE =	Yes
>> >
>> >WANTLIB +=	brotlicommon brotlidec c crypto m ssh2 ssl
>> >
>> >BUILD_DEPENDS =	lang/nim
>> >LIB_DEPENDS =	security/libssh2 archivers/brotli
>> >
>> >FAKE_FLAGS =	PREFIX=${LOCALBASE} MANPREFIX=${LOCALBASE}/man
>> >TEST_FLAGS =	NIMC="nim --nimcache:${NIMCACHE} c" NIM="nim --nimcache:${NIMCACHE}"
>> >NIMCACHE =	${WRKDIR}/nimcache
>> >USE_GMAKE =	Yes
>> >
>> >WRKDIST =	${WRKDIR}/chawan-v$V
>> >
>> >pre-test:
>> >	mkdir -p ${NIMCACHE}
>> >
>> >.include <bsd.port.mk>
>> >
>> >--
>> >Don't know if that reads better. Thoughts?
>> Aren't there usually spaces after the equals sign except when semantically important?
>> 
>
>For comparison:
>
>--- Makefile.orig	Thu Aug  6 09:58:48 2026
>+++ Makefile	Thu Aug  6 09:52:52 2026
>@@ -1,12 +1,13 @@
>-V =	0.4.4
> ONLY_FOR_ARCHS =	amd64 arm64 i386 # Nim arches
>+
> COMMENT =	TUI web/Gopher/Gemini/SFTP browser with CSS and JS support
> DIST_TUPLE +=	srht bptato chawan v$V .
>+V =		0.4.4
> 
> CATEGORIES =	www net sysutils
> HOMEPAGE =	https://chawan.net/
> 
>-MAINTAINER =		Lydia Sobot <chilledfrogs@disroot.org>
>+MAINTAINER =	Lydia Sobot <chilledfrogs@disroot.org>
> 
> # Public Domain/Unlicense,
> # see https://git.sr.ht/~bptato/chawan/tree/HEAD/res/license.md for deps
>@@ -20,9 +21,9 @@ LIB_DEPENDS =	security/libssh2 archivers/brotli
> FAKE_FLAGS =	PREFIX=${LOCALBASE} MANPREFIX=${LOCALBASE}/man
> TEST_FLAGS =	NIMC="nim --nimcache:${NIMCACHE} c" NIM="nim --nimcache:${NIMCACHE}"
> NIMCACHE =	${WRKDIR}/nimcache
>-USE_GMAKE =		Yes
>+USE_GMAKE =	Yes
> 
>-WRKDIST =		${WRKDIR}/chawan-v$V
>+WRKDIST =	${WRKDIR}/chawan-v$V
> 
> pre-test:
> 	mkdir -p ${NIMCACHE}
>
>--
>An attempt to keep the tabbing more consistent? Spelling/grammar looks
>fine in pkg/DESCR and Makefile.
This time around looks nice, maybe it was just a display error on my end