Hi Job,

I put munin's MAINTAINER on Cc.

On Tue, Aug 04, 2026 at 10:25:09PM +0000, Job Snijders wrote:
> When running "munin-node-configure --shell" on a new box, the amavis
> plug always gets enabled even though amavis is not installed.
> 
> I think the amavis plugin 'autoconf' stanza should perform more checks
> than just whether /var/log/maillog and /usr/local/bin/logtail exist.
> 
> Perhaps like so?

A couple of thoughts.

I think it makes sense to do *something* about this since it's indeed
odd to enable amavis even when it's not available.

However, howto do it I think depends on whether we want to upstream the
patch.

There's a couple of possibilities:
- We go with a patch like yours. If we don't want to upstream it, I
  think the patch is fine as is. If we do want to upstream it, we'd
  need to just invoke "amavisd" instead of using the full path, or make
  it possible to specify the amavisd location using an environment
  variable, see e.g. how "SMBSTATUS" is handled in samba.in.
- courier_.in also has an interesting approach: autodetect always says
  "no" because (quoting the file):
        # Makes no sense for wildcard plugin to autoconf to yes
        # unless you can provide suggestions.
  So they make you enable it by hand, always. I guess a similar case
  can be made for amavis. mailscanner.in doesn't provide an autoconf
  capability so also defaults to "no".

kirby@, what do you think? Is Job's patch OK or should it be more
generic/upstreamable?

I'm fine with either approach, but I'd like kirby@ to be OK with it
as he's the maintainer of the port.

Either way, if this were to be committed, a REVISION bump is also
necessary (so increase REVISION in the Makefile by 1).

Caspar