there is another slight issue with the way the port works now

if you do make update-patches *after* a build, it will result in some 
very whacky changes to the mozconfig patch, because it's patched in 
patches/ but then further modified by pre-configure

so now i make sure to run make update-patches before i build. which is 
preferable anyway.

i probably could add something to the Makefile to mitigate this (modify 
mach to use e.g. mozconfig.obsd, or just copy back the originally 
patched version after a build - the latter method would not solve the 
problem on partial builds)


Am 01.09.26 um 19:40 schrieb Leah Rowe:
>
> yeah, was gonna say. use the latest cvs/git mirror and it should all 
> be there. DISTFILES.profdata is now set conditionally in mozilla/
>
> Landry, do not merge yaydn's patch. it disables PGO!
>
> yes yaydn, this is what i get on the latest cvs/git:
>
> shitbox# make package
> ===> Building from scratch librewolf-155.0pl1p0
> ===>  Checking files for librewolf-155.0pl1p0
> >> Fetch 
> https://librewolf.dev/api/packages/librewolf/generic/librewolf-source/155.0-1/librewolf-155.0-1.source.tar.gz
> librewolf-155.0-1.sour... 100% 
> |***************************************************************************************************************************************| 
> 1121 MB    01:26
> >> Fetch 
> https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cNOKkWdaQfOqEzllBpy9Rw/runs/0/artifacts/public/build/profdata.tar.xz
> profdata.tar.xz 100% 
> |*************************************************************************************************************************************************| 
> 18440 KB    00:04
> >> (SHA256) all files: OK
>
> works for me (tm)
>
> Am 01.09.26 um 18:57 schrieb yaydn@protonmail.com:
>> På tirsdag 1. september 2026 kl. 19:00, skrev
>> <yaydn@protonmail.com>:
>>
>>> På tirsdag 1. september 2026 kl. 16:42, skrev Leah Rowe
>>> <info@minifree.org>:
>>>
>>>> well ahead of you.
>>>>
>>>> i'm about to send a new patch fixing the oversight.
>>>>
>>>>
>>> Leah, the files don't fetch in the current version, nor with the last
>>> patch?
>>>
>>> $ cd /usr/ports/www/librewolf/ && make fetch
>>> ===>  Checking files for librewolf-155.0pl1p0
>>> `/usr/ports/distfiles/mozilla/librewolf-155.0-1.source.tar.gz' is up 
>>> to date.
>>>>> No size recorded for mozilla/librewolf-155.0-1.source-profdata.tar.gz
>>> *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:3322 
>>> '/usr/ports/distfiles/mozilla/librewolf-155.0-1.source-profdata.tar.gz': 
>>> @lo...)
>>> *** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2594 
>>> '_internal-fetch': @cd /usr/ports/www/librewolf && 
>>> PKGPATH=www/librewolf exe...)
>>> *** Error 2 in /usr/ports/www/librewolf 
>>> (/usr/ports/infrastructure/mk/bsd.port.mk:2722 'fetch': 
>>> @lock=librewolf-155.0pl1p0;  export _LOCKS_H...)
>>> -- 
>>>
>>> Here is quick and dirty patch with the changes in
>>> 0001-www-librewolf-run-make-update-patches-bump-SO_VERSIO.patch
>>>
>>> I apologize for the ugly, but am not knowledgeable enough about that
>>> magic.
>>>
>>> What is in cvs now will break a bulk build.
>>>
>>> Currently building this.
>>>
>>> Hope this helps.
>>> -- 
>>> yaydn
>>>
>>>
>>
>> Nevermind. Sorry, my www/mozilla/mozilla.port.mk was not up to date.
>>
>> Sorry for the noise.
>> -- 
>> yaydn
>>
>>>
>>>> Am 01.09.26 um 15:24 schrieb landry@openbsd.org:
>>>>> Le Tue, Sep 01, 2026 at 02:59:45PM +0100, Leah Rowe a écrit :
>>>>>> question:
>>>>>>
>>>>>> how can I know reliably when to update SO_VERSION? i assume this 
>>>>>> is when the
>>>>>> one or more of the library dependencies gets updated, but I can't 
>>>>>> be sure.
>>>>>>
>>>>>> Can someone tell me?
>>>
>>> To add to Landry's response, the 'make check-shlib-syms' can tell 
>>> you if something
>>> changed(added, removed); this requires /usr/src from cvs by the way.
>>> Then you can bump if any shared library has changed or if you think
>>> something internal changed to warrant a bump even if this check says
>>> nothing changed. Or generally for a major revision of a port, like
>>> Landry says, bump.
>>>
>>> For this port specifically, you can match any bump in
>>> mozilla-firefox.
>>>
>>>
>>>>> https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs
>>>>>
>>>>> but that's a bit special with monsters, i bump by habit at each major
>>>>> release but noone should care, since nothing links against the 
>>>>> mozilla libs.
>>>>>
>>>>> fwiw i've commited the previous iteration of the diff because i 
>>>>> had to
>>>>> move on to other things. follow cvs commits...
>>>> -- 
>>>> Company director, Minifree Ltd
>>>> Registered in England, No. 9361826 | VAT No. GB202190462
>>>> Registered Office: 19 Hilton Road, Canvey Island, Essex SS8 9QA, UK
>>>>
>>>>
-- 
Company director, Minifree Ltd
Registered in England, No. 9361826 | VAT No. GB202190462
Registered Office: 19 Hilton Road, Canvey Island, Essex SS8 9QA, UK

• OpenPGP_0x5C654067D383B1FF.asc (3K)