Index | Thread | Search

From:
Volker Schlecht <openbsd-ports@schlecht.dev>
Subject:
Re: shells/nushell: drop current_exe() workaround
To:
ports@openbsd.org, "Kirill A. Korinsky" <kirill@korins.ky>
Date:
Sun, 6 Sep 2026 17:33:00 +0200

Download raw body.

Thread
ok

On 9/5/26 5:17 PM, Kirill A. Korinsky wrote:
> Volker,
> 
> rust in ports contains a patch to use getexecpath() for current_exe() that
> makes this workaround outdate.
> 
> make test works the same before and after I had dropped that patch as:
> 
> test result: FAILED. 1820 passed; 8 failed; 27 ignored; 0 filtered out; across 6 groups, finished in 16.96s
> 
> Ok to drop it?
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/shells/nushell/Makefile,v
> diff -u -p -r1.30 Makefile
> --- Makefile	11 Jul 2026 20:21:04 -0000	1.30
> +++ Makefile	5 Sep 2026 15:16:15 -0000
> @@ -5,6 +5,7 @@ COMMENT =		new type of shell
>   GH_ACCOUNT =		nushell
>   GH_PROJECT =		nushell
>   GH_TAGNAME =		0.114.1
> +REVISION =		0
>   
>   MAINTAINER =		Volker Schlecht <volker@openbsd.org>
>   
> Index: patches/patch-src_main_rs
> ===================================================================
> RCS file: patches/patch-src_main_rs
> diff -N patches/patch-src_main_rs
> --- patches/patch-src_main_rs	5 Jul 2026 11:54:18 -0000	1.8
> +++ /dev/null	1 Jan 1970 00:00:00 -0000
> @@ -1,13 +0,0 @@
> -Index: src/main.rs
> ---- src/main.rs.orig
> -+++ src/main.rs
> -@@ -41,8 +41,7 @@ use std::{
> -
> - /// Get the directory where the Nushell executable is located.
> - fn current_exe_directory() -> PathBuf {
> --    let mut path = std::env::current_exe().expect("current_exe() should succeed");
> --    path.pop();
> -+    let mut path = PathBuf::from("${PREFIX}");
> -     path
> - }
> -
> 
>