Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: [IMPROVEMENT] add dependency to devel/crush
To:
David Uhden Collado <daviduhden@gmail.com>
Cc:
ports@openbsd.org, kirill@korins.ky
Date:
Tue, 29 Sep 2026 08:08:20 +0100

Download raw body.

Thread
missing bump.

this change means that crush is no longer installable on some archs.

On 2026/09/28 16:15, David Uhden Collado wrote:
> Hello,
> 
> Please find attached a small patch for devel/crush that adds:
> 
> RUN_DEPENDS = textproc/ripgrep
> 
> Crush's grep and glob agent tools prefer to use ripgrep when it is
> available, falling back to their pure-Go implementation otherwise.
> 
> Since ripgrep is the preferred backend for these tools, I think it makes
> sense to install it as a runtime dependency so the packaged version uses
> the upstream-preferred implementation by default.
> 
> I also added a short comment to the Makefile documenting why the
> dependency is present.
> 
> No other changes are included.
> 
> Thank you for your time and consideration.
> 
> Best regards,
> David.

> Index: devel/crush/Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/crush/Makefile,v
> diff -u -p -u -p -r1.5 Makefile
> --- devel/crush/Makefile	26 Sep 2026 09:37:51 -0000	1.5
> +++ devel/crush/Makefile	28 Sep 2026 16:01:03 -0000
> @@ -17,6 +17,11 @@ WANTLIB += c pthread
>  
>  MODULES =		lang/go
>  
> +# The grep and glob agent tools use ripgrep when it is available and fall
> +# back to a pure-Go implementation otherwise.
> +RUN_DEPENDS =		textproc/ripgrep
> +
> +# Upstream release binaries inject the tag version into internal/version.
>  MODGO_LDFLAGS +=	-X github.com/charmbracelet/crush/internal/version.Version=${MODGO_VERSION}
>  
>  .include "modules.inc"