Index | Thread | Search

From:
Thomas Frohwein <tfrohwein@fastmail.com>
Subject:
Re: love/12: update to latest with bugfix, take MAINTAINER
To:
Stuart Henderson <stu@spacehopper.org>
Cc:
ports@openbsd.org, Omar Polo <op@openbsd.org>
Date:
Wed, 14 Oct 2026 16:07:29 -0700

Download raw body.

Thread
On Tue, 22 Sep 2026 07:06:14 +0100
Stuart Henderson <stu@spacehopper.org> wrote:

> On 2026/09/21 21:21, Thomas Frohwein wrote:
> > Hi,
> > 
> > I would like to update the port of love/12 to the latest commit [1].
> > This fixes a double-free when File:read fails. I don't know for
> > sure, but this seems to improve the intermittent, unpredictable
> > segfaults in luajit that I've seen with the previous version when
> > playing Snacktorio. The game seems to work flawlessly now in >1-2
> > hours of testing. Also tested with Beatblock. Game controllers like
> > the XBox One controller work now with the SDL3 game controller fix
> > [2].
> > 
> > I would like to take MAINTAINER for love/12, as I use it regularly.
> > 
> > Overall a straightforward diff. I chose version alpha0.1 to avoid
> > colliding with any potential future official labeling as alpha,
> > though unlikely.  
> 
> $ pkg_check-version love-12.0alpha0 love-12.0alpha0.1 love-12.0
> love-*- sorted: love-12.0alpha0 love-12.0 love-12.0alpha0.1
> 
> I would just go with alpha1, or possibly use the commit date e.g.
> alpha20260920.

Thanks, I changed it to alpha1. I also realized that ../Makefile.inc
needs MAINTAINER line changed from = to ?= for this to work, so new
diff below (still to same commit). I'm including a change to WRKDIST
away from the "hack" of using _DT_WRKDIST which is problematic with the
planned update to DIST_TUPLE in the near future.

Still builds and packages as expected.

ok?

Index: Makefile.inc
===================================================================
RCS file: /cvs/ports/games/love/Makefile.inc,v
diff -u -p -r1.7 Makefile.inc
--- Makefile.inc	17 Sep 2026 23:23:51 -0000	1.7
+++ Makefile.inc	14 Oct 2026 23:04:34 -0000
@@ -7,7 +7,7 @@ CATEGORIES +=	games
 
 HOMEPAGE =	https://love2d.org/
 
-MAINTAINER =	Omar Polo <op@openbsd.org>
+MAINTAINER ?=	Omar Polo <op@openbsd.org>
 
 # zlib
 PERMIT_PACKAGE =	Yes
Index: 12/Makefile
===================================================================
RCS file: /cvs/ports/games/love/12/Makefile,v
diff -u -p -r1.1.1.1 Makefile
--- 12/Makefile	17 Sep 2026 23:21:46 -0000	1.1.1.1
+++ 12/Makefile	14 Oct 2026 23:04:34 -0000
@@ -6,11 +6,14 @@ USE_WXNEEDED =		Yes
 
 VERSION =		12.0
 PKGSPEC =		love->=${VERSION},<13
+H =			b7daef0f7c1dc5888090f5d5b22d4eaf4ffd1d87
 
 SITES =
 DISTNAME =
-PKGNAME =		love-${VERSION}alpha0
-DIST_TUPLE =		github love2d love 4e167072ae558e114cacec28ad5abb2ec2cdf05c .
+PKGNAME =		love-${VERSION}alpha1
+DIST_TUPLE =		github love2d love ${H} .
+
+MAINTAINER =		Thomas Frohwein <thfr@openbsd.org>
 
 SHARED_LIBS =		love-${VERSION}	0.0
 
@@ -36,7 +39,7 @@ RUN_DEPENDS =		devel/desktop-file-utils 
 
 PORTROACH =
 
-WRKDIST =		${_DT_WRKDIST}
+WRKDIST =		${WRKDIR}/love-${H}
 
 # disable some defaults for pre-12.0 love
 CONFIGURE_STYLE =
Index: 12/distinfo
===================================================================
RCS file: /cvs/ports/games/love/12/distinfo,v
diff -u -p -r1.1.1.1 distinfo
--- 12/distinfo	17 Sep 2026 23:21:46 -0000	1.1.1.1
+++ 12/distinfo	14 Oct 2026 23:04:34 -0000
@@ -1,2 +1,2 @@
-SHA256 (love2d-love-4e167072ae558e114cacec28ad5abb2ec2cdf05c.tar.gz) = uQMvVRRceIskTMMwtkeTFIOy2/jHCzncZ6LdmPz/BMU=
-SIZE (love2d-love-4e167072ae558e114cacec28ad5abb2ec2cdf05c.tar.gz) = 7276238
+SHA256 (love2d-love-b7daef0f7c1dc5888090f5d5b22d4eaf4ffd1d87.tar.gz) = e1+oInbOru4iIEtOpk9H44J4iW0BDuq7XV7uiGmKv14=
+SIZE (love2d-love-b7daef0f7c1dc5888090f5d5b22d4eaf4ffd1d87.tar.gz) = 7276228