From: Klemens Nanni <kn@openbsd.org>
Subject: Re: [NEW/wip]: devel/py3-bdfparser - library for parsing BDF fonts
To: Корякин Артём <karakin2000@gmail.com>
Cc: Stuart Henderson <stu@spacehopper.org>, ports@openbsd.org
Date: Thu, 18 Jan 2024 23:27:21 +0000

On Sun, Jan 07, 2024 at 05:12:34AM +0300, Корякин Артём wrote:
> Hello, thanks for responding.
> 
> > This tries to replace "py" with "py-" from DISTNAME, but there is
> > no py in DISTNAME. I think it should just use
> >
> > PKGNAME=	py-${DISTNAME}
> 
> It really should, thanks for pointing this out.
> I rewrited this.
> 
> >> +CATEGORIES=	devel
> >
> > devel is quite a busy category and it's usually better to choose another
> > if possible. I think perhaps graphics might be better (or maybe even
> > sysutils).
> 
> Moved to sysutils category.
> 
> > Please add a HOMEPAGE, I think either https://font.tomchen.org/bdfparser_py/
> > or https://github.com/tomchen/bdfparser would do.
> 
> Added first web page as a HOMEPAGE.
> 
> >> --- /dev/null
> >> +++ b/pkg/DESCR
> >> @@ -0,0 +1,6 @@
> >> +BDF format bitmap font file parser library in Python. It has Font,
> >> +Glyph and Bitmap classes providing more than 30 chainable API methods
> >> +of parsing BDF fonts, getting their meta information, rendering text
> >> +in any writing direction, adding special effects and manipulating
> >> +bitmap images. It works seamlessly with PIL / Pillow and NumPy, and
> >> +has detailed documentation / tutorials / API reference.
> >> \ No newline at end of file
> >
> > Should have a newline at end of file.
> 
> Yep, I added it. For some reason I thought that ports is simillar to
> tech@ in fact that only textual patches would be applied and I used git
> send-email. In the second commit I added newline, but turns out that
> git send-email --to=ports@openbsd.org HEAD~2 --relative .
> would not create a draft with two commits in one email, but two
> emails. Sorry.
> 
> > The rest looks good, so with those changes I'd give an ok for someone to
> > import it.
> >
> > If possible we would prefer an attached tar.gz for new ports; applying
> > git diffs to a cvs tree for import is a bit of a pain.
> 
> Sorry, py3-bdfparser.tar.gz would be attached as attachment with
> application/x-tar MIME type.
> 
> Best regards, Arstiom.

Pretty sure this needs the usual FLAVOR dance, otherwhise pkgname/path
mismatch (regardless, the ports directory needs to be named py-*):

	$ make show='FULLPKGNAME FULLPKGPATH'
	py3-bdfparser-2.2.0
	graphics/py-bdfparser

Also, I slightly prefer graphics/ over sysutils/ here.

OK kn to import that, or I'll import with OK sthen in a few days unless
there are objections.