From: izder456 Subject: Re: NEW: games/Bugdom2 To: ports@openbsd.org Date: Fri, 19 Jan 2024 13:06:36 -0600 On Mon, 15 Jan 2024 22:45:42 -0600 izder456 wrote: > On Mon, 15 Jan 2024 17:07:18 +0100 > izder456 wrote: > > > On 2024-01-15 10:10, Kirill Bychkov wrote: > > > On Mon, January 15, 2024 02:09, izder456 wrote: > > >> Hey, > > >> > > >> (In line with my earlier mesg) > > >> > > >> I would like to import Bugdom 2 > > >> (https://github.com/jorio/Bugdom2), which is an old Mac game > > >> that has a source port for modern systems. > > >> > > >> Its just a simple old Nostalgic game for me, the port can be > > >> found here: > > >> (https://github.com/izder456/myports) > > >> > > >> Comments or OK to import? > > >> -- > > >> -iz > > >> > > >> > > > Hi, > > > Please attach the port as a tarball. > > > > Hey sorry, > > > > Attached is the tarball. > > > > new to port maintenance. > > > > hopefully i packaged this up as i should have. > > > > -- > > -iz > > 1. > Attached is a modified version of this port with Thomas' > (CC'd) reccomendations > > 2. > Quick Summary of changes made: > > - The game's CC-BY-NC-SA license is not ideal for software, as it does > not address source code redistribution and modification. While this > is an upstream issue, it affects our ability to PERMIT_PACKAGE. > > - Additionally, it appears that the license is not applied to the > source code files, although I made an attempt to reference trademark > and copyright in DESCR. Unsure if this is the right way to handle > this.[1] > > - I would like an other's perspective on this, Prefereably Iliyas > Jorio, or Pangea Soft., as they are upstream. > > - changed games/Bugdom2 -> games/bugdom2 (standard for ports tree), no > need for uppercase here. > > - favored spaced over tabs. > > - omitted FULLPKGNAME. > > - swapped out GH_* for DIST_TUPLE, (thanks Thomas for the tip!). this > makes the port way simpler to manage git submodules. > > - cleaned up do-install target with globbing, and removed unnessesary > lines. > > - removed exec perm in files/bugdom2, `${INSTALL_SCRIPT}` will handle > perms for me, I assume. > > - I removed `ONLY_FOR_ARCHS=amd64 i386`. I originally had this as I > only have amd64 and i386 installs available to me. I would like > testing done on other architectures, if possible. > > - changed COMMENT line and DESCR to closer reflect the port's > contents. (see [1]) > > 3. > TL;DR: > > - Need some other opinions on PERMIT_PACKAGE, CC licensed software. > > - Want testing done on other architectures, if possible. > > 4. > > I think we should hold on a merge until those things get cleared up. > > OK? > Hey again, like my games/bugdom port, I Fixed up and patched to mirror games/nanosaur2 from omar. it was a simple enough patch. Attached is the port. Comments or O.K. to merge? -- -iz > If something is shit and no one likes it, you just put out another one the next month. Stu