From: Renaud Allard Subject: [new] security/certspotter 0.16.0 To: ports Date: Tue, 13 Feb 2024 08:22:24 +0100 ping -------- Forwarded Message -------- Subject: Re: [new] security/certspotter 0.16.0 Date: Thu, 26 Oct 2023 13:27:07 +0200 From: Renaud Allard To: ports@openbsd.org Hello and thanks for checking On 10/26/23 13:07, Stefan Hagen wrote: > Renaud Allard wrote (2023-10-25 09:46 CEST): >> Hello, >> >> Here is a new port for certspotter. This needs a change in user.list for the >> daemon user. >> Tested on amd64. > On the first look: > > $ portcheck > trailing whitespace in pkg/README > missing share/doc/pkg-readmes/${PKGSTEM} in PLIST > > $ make port-lib-depends-check > Missing: c.97 (/usr/local/bin/submitct) (system lib) > Missing: pthread.27 (/usr/local/bin/submitct) (system lib) > WANTLIB += c pthread > > In pkg/README, the {LOCALSTATEDIR} is missing a $. > > Why are you moving the watchlist to ${LOCALSTATEDIR}/certspotter, > while everything else goes into ${LOCALSTATEDIR}/certspotter/.certspotter? > > I see that not all files can be moved. There's only -watchlist and -state-dir, > which is not enough to move everything. > > For simplicity sake, I'd just let all files reside in > ${LOCALSTATEDIR}/certspotter/.certspotter/ > > Best regards, > Stefan Here is a better version. All config files are left in ${LOCALSTATEDIR}/certspotter/.certspotter/ I also tested it on arm64 Any other suggestions or OKs? Index: user.list =================================================================== RCS file: /cvs/ports/infrastructure/db/user.list,v retrieving revision 1.430 diff -u -p -r1.430 user.list --- user.list 15 Aug 2023 15:54:30 -0000 1.430 +++ user.list 25 Oct 2023 07:15:08 -0000 @@ -402,3 +402,4 @@ id user group port 891 _kiwix-serve _kiwix-serve www/kiwix/kiwix-tools 892 _shiori _shiori www/shiori 893 _azorius _azorius www/azorius +894 _certspotter _certspotter security/certspotter