From: Renaud Allard Subject: Re: Update to dnsdist 1.9.0, with new flavor To: ports@openbsd.org Date: Fri, 16 Feb 2024 13:20:42 +0100 On 2/16/24 12:37, Otto Moerbeek wrote: > On Fri, Feb 16, 2024 at 10:20:49AM +0000, Stuart Henderson wrote: > >> Generally the diff looks good to me. I'd have a slight preference to >> move SYSCONFDIR/COMPILER/MODULES/NODLUA_VERSION up so that the >> flavour-independent variables are grouped together above the .if. >> >> On 2024/02/16 10:29, Renaud Allard wrote: >>> Then maybe the flavor should be named -http3 because DoQ is http3 over non >>> 443 port. >> >> I would prefer this (or just -h3) than -quiche. Also please mention >> it in DESCR e.g. something like >> >> Flavours: >> h3: build with libquiche/boringssl, providing HTTP/3 and QUIC support >> > > On a side note, "DoQ is http3 over another port" is not true, there is > no http layer involved in DoQ, it's more like TCP over QUIC. So the > -h3 name is not ideal, but good enough. > Yes, it's not exactly the same, but the idea is there and the library is the same. But using -quiche would have caused issues if they changed their mind and used another library called tart or whatever in the future.