From: Jeremie Courreges-Anglas Subject: Re: switch tacacs+ to python3 To: Daniel Dickman Cc: Jan Vlach , ports@openbsd.org Date: Mon, 19 Feb 2024 23:03:56 +0100 On Mon, Feb 19 2024, Stuart Henderson wrote: > On 2024/02/19 10:46, Daniel Dickman wrote: >> >> >> On Mon, 19 Feb 2024, Stuart Henderson wrote: >> >> > On 2024/02/19 10:21, Daniel Dickman wrote: >> > > >> > > >> > > On Mon, 19 Feb 2024, Jeremie Courreges-Anglas wrote: >> > > >> > > > On Sat, Feb 17 2024, Daniel Dickman wrote: >> > > > > Hello Jan, ports@, >> > > > > >> > > > > Please see below for a small update so tacacs+ doesn't need python2. >> > > > > >> > > > > It also looks like python2 is not needed at build time, but only at run >> > > > > time. >> > > > > >> > > > > ok to commit the diff below? >> > > > >> > > > do_auth.py isn't ready for python3, if you really want to move this to >> > > > python3 I would suggest using 2to3 -w in eg post-extract (and thus keep >> > > > current MODPY_BUILDDEP). >> > > > >> > > >> > > Indeed I botched the diff I sent out. I had run do_auth.py through 2to3 >> > > and made a patch that should have been part of the original diff. >> > > >> > > The reason I made a patch instead of running 2to3 dynamically is because >> > > it is only 1 file and more changes might be needed in do_auth.py to adapt >> > > to future python updates in the future. >> > >> > However, the diff for any future patches needed will be shorter if it's >> > made on top of 2to3's output (as would be the case with 2to3 run in >> > post-extract). >> > >> > > ok on this revised version? >> > >> > I'd slightly prefer 2to3 in do-extract (plus drop MODPY_BUILDDEP=No), >> > but I'm ok with either. >> > >> >> okay, here is that version instead. > > thanks, OK sthen. Also ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE