From: Thomas Frohwein <tfrohwein@fastmail.com>
Subject: Re: sdl2-mixer, explicitely disable wavepack and xmp
To: Antoine Jacoutot <ajacoutot@bsdfrog.org>
Cc: Thomas Frohwein <thfr@openbsd.org>, ports@openbsd.org
Date: Sun, 25 Feb 2024 09:15:32 -0500

On Sun, Feb 25, 2024 at 01:17:44PM +0100, Antoine Jacoutot wrote:
> Hi.
> 
> This diff to prevent libxmp and libwavepack from being picked up.
> Or we do the opposite and add support, I have no opinion.

Thanks for spotting this. These are new dlopen(3)'d dependencies via
SDL_LoadObject. I prefer that we keep them enabled and add the
dependencies properly, as sdl2 stuff is used in so many contexts.
I committed the pertinent revision that adds the dependencies.
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/sdl2-mixer/Makefile,v
> retrieving revision 1.17
> diff -u -p -r1.17 Makefile
> --- Makefile	23 Feb 2024 20:35:32 -0000	1.17
> +++ Makefile	25 Feb 2024 12:17:30 -0000
> @@ -24,6 +24,8 @@ LIB_DEPENDS =	audio/opusfile \
>  
>  CONFIGURE_STYLE =	gnu
>  CONFIGURE_ARGS +=	--disable-music-midi-fluidsynth \
> +			--disable-music-wavpack \
> +			--disable-music-mod-xmp \
>  			--disable-music-mod-modplug-shared \
>  			--disable-music-opus-shared
>  
> 
> -- 
> Antoine