From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: [new] devel/sbt 1.9.8
To: OpenBSD ports <ports@openbsd.org>, kirill@korins.ky
Date: Wed, 28 Feb 2024 17:53:44 +0000

On 2024/02/24 23:38, Kirill A. Korinsky wrote:
> Greetings,
> 
> A new version of sbt was released, and I've updated port file.
> 
> If someone can review it, I'll be appricieted.
> 
> -- 
> wbr, Kirill

quick comments:

COMMENT=        sbt, the interactive build tool
- don't repeat "sbt", it's in PKGNAME anyway which is displayed next to
this. suggest e.g. "interactive build tool for Scala"

REVISION=       0
- new port, doesn't need REVISION

        ${SUBST_CMD} -m 755 -c ${FILESDIR}/sbt ${PREFIX}/bin/sbt
- there's a specialist thing for that
${SUBST_PROGRAM} ${FILESDIR}/sbt ${PREFIX}/bin/sbt

"For general documentation, see https://www.scala-sbt.org/."
- in the generated file in the package this is followed immediately
by "WWW: https://scala-sbt.org" from HOMEPAGE i.e. dup info

@comment libexec/sbt/bin/sbt.beforesubst
- might as well add this to the find ... -delete

otherwise reads ok (untested)