From: Jeremie Courreges-Anglas Subject: Re: gnustep/libobjc2 and BTI (was: Re: x11/gnustep/libobjc2 failed to build) To: Sebastian Reitenbach Cc: Mark Kettenis , tb@openbsd.org, stu@spacehopper.org, ajacoutot@bsdfrog.org, ports@openbsd.org Date: Thu, 7 Mar 2024 12:19:33 +0100 Le Thu, Mar 07, 2024 at 10:28:21AM +0100, Mark Kettenis a écrit : > > From: "Sebastian Reitenbach" > > Date: Thu, 07 Mar 2024 09:01:13 +0100 > > > > Hi, > > > > On Wednesday, March 06, 2024 23:42 CET, Mark Kettenis wrote: > > > > > > Date: Wed, 06 Mar 2024 23:32:51 +0100 > > > > From: Mark Kettenis > > > > > > > > > Date: Wed, 6 Mar 2024 19:02:35 +0100 > > > > > From: Jeremie Courreges-Anglas > > > > > > > > > > Le Wed, Mar 06, 2024 at 10:17:32AM +0100, Theo Buehler a écrit : > > > > > > Could you please resend the endbr64 patches with Cc kettenis? They > > > > > > should make release. > > > > > > > > > > Since I now have a laptop with BTI I figured I was going to give this > > > > > a try. -current x11/gnustep/zipper was crashing with SIGILL on amd64. > > > > > For the amd64 diff I'm deliberately not caring about the assembly for > > > > > Windows. I can't test the arm64 part but it looks simple. > > > > > > > > > > ok? > > > > > > > > > > Sebastian, feel free to commit this if it matches your previous diff. > > > > > > > > Looks right to me. > > > > > > Actually, the arm64 bit is probably incomplete. And tb@ has a point > > > that endbr64 should be after the .cfi_startproc. > > > > > > > I already created a lot of mess rushing getting the update in, I'm > > a bit confused with this back and fourth. Before messing up even more, > > which of these should be the correct version, the one from tb@ or jca@ ? Well I added to the confusion. I did not have tb's diff at hand yesterday, I cooked a subpar diff that fixed the crash and got trigger happy. That's a waste of time, sorry folks. > > And that one would also be complete in aarch64? > > If I got all those threats right, the tb@ version would be the correct one? > > Both attached below. > > > > > > How do I get a BTI enabled machine? Apparently most Intel Gen11+ CPUs have IBT. For arm64 you need an Apple M2. > > Sebastian > > > > tb@ version: > > This version looks best to me. Agreed. > But I suspect arm64 needs more work in > this version too. > > ok kettenis@ ok jca@ -- jca