From: Klemens Nanni <kn@openbsd.org>
Subject: Re: UPDATE: Dolphin 20230722
To: Brad Smith <brad@comstyle.com>
Cc: ports@openbsd.org
Date: Sat,  6 Apr 2024 13:39:21 +0000

On Thu, Apr 04, 2024 at 07:47:25PM -0400, Brad Smith wrote:
> On Thu, Apr 04, 2024 at 05:12:33PM -0400, Brad Smith wrote:
> > On Thu, Apr 04, 2024 at 05:01:07PM -0400, Brad Smith wrote:
> > > On Thu, Apr 04, 2024 at 05:54:52AM -0400, Brad Smith wrote:
> > > > Here is an update to Dolphin 20230722 snapshot.
> > > > 
> > > > I thought I had sent this out.
> > > > 
> > > > This fixes the Minizip and mGBA build issues Klemens had pointed out.
> > >  
> > > I have converted the setup to using DIST_TUPLE.
> > > 
> > > More testing welcome.
> >  
> > Fix a typo.
> 
> Roll up to the latest code just before newer fmt is required.

Diff looks fine, but I see

	$ make port-lib-depends-check

	dolphin-5.0.0.20230920(emulators/dolphin,-main):
	Missing lib: enet.0 (/usr/local/bin/dolphin-emu) (NOT REACHABLE)

	dolphin-nogui-5.0.0.20230920(emulators/dolphin,-nogui):
	Missing lib: enet.0 (/usr/local/bin/dolphin-tool) (NOT REACHABLE)
	*** Error 1 in target 'port-lib-depends-check' (ignored)

and there's a BTI problem when starting a game .iso:

	Core was generated by `dolphin-emu'.
	Program terminated with signal SIGILL, Illegal instruction.
	#0  0x000009a95047c000 in ?? ()
	[Current thread is 1 (process 571639)]
	(gdb) bt
	#0  0x000009a95047c000 in ?? ()
	#1  0x000009a63bf16693 in Jit64::Run() ()
	#2  0x000009a63bd2f883 in CPU::CPUManager::Run() ()
	#3  0x000009a63bced42a in Core::CpuThread(std::__1::optional<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&, bool) ()
	#4  0x000009a63bcedd9e in void* std::__1::__thread_proxy[abi:v160006]<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(std::__1::optional<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&, bool), std::__1::optional<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, bool> >(void*) ()
	#5  0x000009a8f65d2502 in _rthread_start (v=0x9a92ac1b7f0) at /usr/src/lib/librthread/rthread.c:96
	#6  0x000009a901a9adca in __tfork_thread () at /usr/src/lib/libc/arch/amd64/sys/tfork_thread.S:87