From: Jeremie Courreges-Anglas <jca@wxcvbn.org>
Subject: Re: [NEW] net/crawley-v1.7.5
To: Antoine Jacoutot <ajacoutot@bsdfrog.org>
Cc: Russ Sharek <bsdclown@disroot.org>, Edd Barrett <edd@theunixzoo.co.uk>, ports@openbsd.org
Date: Sat, 11 May 2024 17:45:31 +0200

On Sat, May 11, 2024 at 12:47:21AM +0200, Antoine Jacoutot wrote:
> That’s not a reason to set NO_TEST. 

Correct, thanks a lot for pointing out this bad advice.
To elaborate a bit more: the upstream code does have regression tests
but the port just doesn't know how to run them and errors out. I would
have preferred someone else to just fix that issue.  *sigh*
Upstream's Makefile has a test target but go.port.mk won't use it
I suggest we use this in the port Makefile, instead of setting
NO_TEST=Yes:

# Adapted from the test target in ${WRKSRC}/Makefile
MODGO_TEST_TARGET =	cd ${WRKSRC} && \
	CGO_ENABLED=1 ${MODGO_CMD} test -count 1 -v -tags=test -coverprofile="cover.out" ./...

> —
> Antoine
> 
> > On 11 May 2024, at 00:41, Russ Sharek <bsdclown@disroot.org> wrote:
[...]
> > bump?
> > OK?
> > Edd said it looked good...

I think I gave an ok to Edd some time ago, we'll see if we can
get this in the tree soonish.  I think you don't need to resend a
diff/tarball.

-- 
jca