From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: NEW: security/xhash v3.4.0
To: Ricardo Branco <rbranco@suse.de>
Cc: ports@openbsd.org
Date: Sat, 1 Jun 2024 17:06:44 +0100

On 2024/06/01 11:41, Ricardo Branco wrote:
>  security/xhash/Makefile    | 23 +++++++++++++++++++++
>  security/xhash/distinfo    | 42 ++++++++++++++++++++++++++++++++++++++
>  security/xhash/modules.inc | 12 +++++++++++
>  security/xhash/pkg/DESCR   |  1 +
>  security/xhash/pkg/PLIST   |  1 +
>  5 files changed, 79 insertions(+)
>  create mode 100644 security/xhash/Makefile
>  create mode 100644 security/xhash/distinfo
>  create mode 100644 security/xhash/modules.inc
>  create mode 100644 security/xhash/pkg/DESCR
>  create mode 100644 security/xhash/pkg/PLIST

Please send tars rather than diffs for new ports.

> +V =		3.4.0
> +MODGO_MODNAME =	github.com/ricardobranco777/xhash
> +MODGO_VERSION =	v0.0.0-20240601062954-9bdefd997316
> +DISTNAME =	xhash-${V}

I don't understand what's needed to make the go proxy stuff pick things
up, but it would be nice if this could use the tags rather than a
date+hash version.

> +++ b/security/xhash/pkg/DESCR
> @@ -0,0 +1 @@
> +This Go program uses goroutines to calculate multiple hashes on strings, files and directories.  By default it reads from standard input.  It can be used as a drop-in replacement for the GNU **coreutils** when hard-linked as **md5sum**, etc. and it actually supports the `--zero` option with `--check`.  The output format is fully configurable.

DESCR should be wrapped at <80 columns and plaintext not markdown.

Might be nice to outline which actual hashes are supported - doesn't
need to be in full detail, but something like "Supports a range of SHA
and BLAKE algorithms and can use HMACs" would give a better idea of what
it can do.