From: Kirill A. Korinsky <kirill@korins.ky>
Subject: Re: [new] archivers/py-zstandard
To: Stuart Henderson <stu@spacehopper.org>, OpenBSD ports <ports@openbsd.org>
Date: Mon, 10 Jun 2024 11:14:59 +0100

On Mon, 10 Jun 2024 00:16:17 +0100,
Kirill A. Korinsky <kirill@korins.ky> wrote:
> 
> On Sun, 09 Jun 2024 23:03:50 +0100,
> Stuart Henderson <stu@spacehopper.org> wrote:
> > 
> > I'd expect cffi to use dlopen not static linking. We normally record
> > those as LIB_DEPENDS and WANTLIB with a comment next to the WANTLIB
> > saying "uses dlopen" (check-lib-depends will say 'Extra' in that case).
> >
> 
> Unfortunately, that's not the case here.
> 

and my use case with make uninstall and make install was wrong because I
missed clean.

Long story short, at the end, --system-zstd is usless here.

This project had hardcoded expected version of zstd which is part of
distrivutive: https://github.com/indygreg/python-zstandard/blob/main/c-ext/backend_c.c#L155

Here an issue where it was asked to be relaxed:
https://github.com/indygreg/python-zstandard/issues/132

So, no way to make it with dynamic linking.

And here an updated version with fixed tests.

-- 
wbr, Kirill