From: Jeremie Courreges-Anglas <jca@wxcvbn.org>
Subject: Re: net/tcpflow: fix build
To: ports@openbsd.org
Date: Mon, 10 Jun 2024 20:52:39 +0200

On Mon, Jun 10, 2024 at 03:18:15PM +0100, Kirill A. Korinsky wrote:
> On Mon, 10 Jun 2024 12:54:52 +0100,
> Jeremie Courreges-Anglas <jca@wxcvbn.org> wrote:
> > 
> > On Sun, Jun 09, 2024 at 11:21:58PM +0100, Kirill A. Korinsky wrote:
[...]
> > > Also, I abit tired from created report.xml by tcpflow when using it with -c
> > > and suggested a patch to upstream to avoid that [3] which I've included into
> > > updated diff.
> > 
> > Looking at the tool (I don't use it myself) I suspect you could use
> > tcpflow -X /dev/null -c.  Is this really something where you want to
> > deviate from upstream?  If so, I can add that patch too (I have
> > committed the rest).
> 
> More idiomatic way is tcpflow -S enable_report=NO -c (which is the same
> thing that my patch does). And yes, I'd like to deviate from upstream
> because this is behaviour of tcpflow-0.21 and I expect that this change in
> creating a lot of unexpected report.xml after upgrade to 7.6 isn't somehting
> expected.

Fine with me.  Committed, thanks.

-- 
jca