From: Jag Talon <jag@aangat.lahat.computer>
Subject: Re: [update] sysutils/tarsnap-gui: add desktop entry
To: Rafael Sadowski <rafael@sizeofvoid.org>, ports@openbsd.org, josh@jggimi.net, Stuart Henderson <stu@spacehopper.org>
Date: Wed, 3 Jul 2024 14:48:28 -0400

ah i reconfigured my editor and it should have less whitespace now :)

i added the revision as well thank you. OK?

Index: Makefile
===================================================================
RCS file: /cvs/ports/sysutils/tarsnap-gui/Makefile,v
diff -u -p -u -r1.17 Makefile
--- Makefile	11 Mar 2022 19:58:05 -0000	1.17
+++ Makefile	3 Jul 2024 18:47:20 -0000
@@ -4,6 +4,8 @@ GH_ACCOUNT =		Tarsnap
 GH_PROJECT =		tarsnap-gui
 GH_TAGNAME =		v1.0.2

+REVISION =		1
+
 CATEGORIES =		sysutils

 MAINTAINER =		Josh Grosse <josh@jggimi.net>
@@ -15,9 +17,18 @@ WANTLIB += ${COMPILER_LIBCXX} GL Qt5Core
 WANTLIB += Qt5Widgets c m

 MODULES =		devel/qmake x11/qt5
-RUN_DEPENDS =		sysutils/tarsnap
+RUN_DEPENDS =		sysutils/tarsnap \
+			devel/desktop-file-utils

 do-install:
 	${INSTALL_PROGRAM} ${WRKBUILD}/tarsnap-gui ${PREFIX}/bin/tarsnap-gui
+
+	${INSTALL_DATA_DIR} ${PREFIX}/share/applications/
+	${INSTALL_DATA} ${FILESDIR}/tarsnap-gui.desktop \
+		${PREFIX}/share/applications/
+
+	${INSTALL_DATA_DIR} ${PREFIX}/share/pixmaps/
+	${INSTALL_DATA} ${WRKSRC}/resources/icons/tarsnap-icon-big.png \
+		${PREFIX}/share/pixmaps/tarsnap-gui.png

 .include <bsd.port.mk>
cvs server: Diffing pkg
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/sysutils/tarsnap-gui/pkg/PLIST,v
diff -u -p -u -r1.4 PLIST
--- pkg/PLIST	11 Mar 2022 19:58:05 -0000	1.4
+++ pkg/PLIST	3 Jul 2024 18:47:20 -0000
@@ -1,2 +1,6 @@
 @bin bin/tarsnap-gui
+share/applications/tarsnap-gui.desktop
 share/doc/pkg-readmes/${PKGSTEM}
+share/pixmaps/
+share/pixmaps/tarsnap-gui.png
+@tag update-desktop-database


On 7/3/24 2:26 PM, Rafael Sadowski wrote:
> On Wed Jul 03, 2024 at 05:44:12PM GMT, Stuart Henderson wrote:
>> On 2024/07/03 11:41, Jag Talon wrote:
>>> adding a desktop entry to tarsnap-gui to make it easy to find for users.
>>> it also helps with automation in environments like gnome where it's easy
>>> to select programs with an associated .desktop file.
>>>
>>> attaching the .desktop file and below is the diff.
>>>
>>> OK?
>>>
>>> Index: Makefile
>>> ===================================================================
>>> RCS file: /cvs/ports/sysutils/tarsnap-gui/Makefile,v
>>> diff -u -p -u -r1.17 Makefile
>>> --- Makefile	11 Mar 2022 19:58:05 -0000	1.17
>>> +++ Makefile	3 Jul 2024 15:36:30 -0000
>>> @@ -15,9 +15,19 @@ WANTLIB += ${COMPILER_LIBCXX} GL Qt5Core
>>>  WANTLIB += Qt5Widgets c m
>>
>> missing REVISION bump
>>
>>>
>>>  MODULES =		devel/qmake x11/qt5
>>> -RUN_DEPENDS =		sysutils/tarsnap
>>> +RUN_DEPENDS =		sysutils/tarsnap \
>>> +					devel/desktop-file-utils
>>
>> loads of whitespace!
>>
>>>
>>>  do-install:
>>>  	${INSTALL_PROGRAM} ${WRKBUILD}/tarsnap-gui ${PREFIX}/bin/tarsnap-gui
>>> +
>>> +post-install:
>>
>> no need for post-install, just merge into do-install.
> 
> Yes please, ok rsadowski
> 
>>
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/sysutils/tarsnap-gui/Makefile,v
>> diff -u -p -r1.17 Makefile
>> --- Makefile	11 Mar 2022 19:58:05 -0000	1.17
>> +++ Makefile	3 Jul 2024 16:42:06 -0000
>> @@ -3,6 +3,7 @@ COMMENT =		frontend to the popular Tarsn
>>  GH_ACCOUNT =		Tarsnap
>>  GH_PROJECT =		tarsnap-gui
>>  GH_TAGNAME =		v1.0.2
>> +REVISION =		0
>>  
>>  CATEGORIES =		sysutils
>>  
>> @@ -15,9 +16,16 @@ WANTLIB += ${COMPILER_LIBCXX} GL Qt5Core
>>  WANTLIB += Qt5Widgets c m
>>  
>>  MODULES =		devel/qmake x11/qt5
>> -RUN_DEPENDS =		sysutils/tarsnap
>> +RUN_DEPENDS =		sysutils/tarsnap \
>> +			devel/desktop-file-utils
>>  
>>  do-install:
>>  	${INSTALL_PROGRAM} ${WRKBUILD}/tarsnap-gui ${PREFIX}/bin/tarsnap-gui
>> +	${INSTALL_DATA_DIR} ${PREFIX}/share/applications/ \
>> +		${PREFIX}/share/pixmaps/
>> +	${INSTALL_DATA} ${FILESDIR}/tarsnap-gui.desktop \
>> +		${PREFIX}/share/applications/
>> +	${INSTALL_DATA} ${WRKSRC}/resources/icons/tarsnap-icon-big.png \
>> +		${PREFIX}/share/pixmaps/tarsnap-gui.png
>>  
>>  .include <bsd.port.mk>
>> Index: files/tarsnap-gui.desktop
>> ===================================================================
>> RCS file: files/tarsnap-gui.desktop
>> diff -N files/tarsnap-gui.desktop
>> --- /dev/null	1 Jan 1970 00:00:00 -0000
>> +++ files/tarsnap-gui.desktop	3 Jul 2024 16:42:06 -0000
>> @@ -0,0 +1,9 @@
>> +[Desktop Entry]
>> +GenericName=Backup
>> +Name=Tarsnap Backup
>> +Comment=GUI for the Tarsnap backup service
>> +Exec=tarsnap-gui
>> +Terminal=false
>> +Type=Application
>> +Categories=Utility;Archiving;Qt;
>> +Icon=tarsnap-gui
>> Index: pkg/PLIST
>> ===================================================================
>> RCS file: /cvs/ports/sysutils/tarsnap-gui/pkg/PLIST,v
>> diff -u -p -r1.4 PLIST
>> --- pkg/PLIST	11 Mar 2022 19:58:05 -0000	1.4
>> +++ pkg/PLIST	3 Jul 2024 16:42:06 -0000
>> @@ -1,2 +1,6 @@
>>  @bin bin/tarsnap-gui
>> +share/applications/tarsnap-gui.desktop
>>  share/doc/pkg-readmes/${PKGSTEM}
>> +share/pixmaps/
>> +share/pixmaps/tarsnap-gui.png
>> +@tag update-desktop-database
>>
> 

-- 
jagtalon.net
weirder.earth/@jag