From: Thomas Frohwein <tfrohwein@fastmail.com>
Subject: Re: [update] sysutils/tarsnap-gui: add desktop entry
To: Jag Talon <jag@aangat.lahat.computer>
Cc: ports@openbsd.org, Josh Grosse <josh@jggimi.net>
Date: Wed, 3 Jul 2024 21:48:32 -0400

On Wed, Jul 03, 2024 at 07:22:46PM -0400, Jag Talon wrote:
> Thank you for adjusting the REVISION! I should've read the man page
> first.
> 
> How do you get the diff of a new file, btw?

Speaking mainly for cvs(1), after I `cvs add path/to/file`, the file is
now included in the diff (all + compared to /dev/null). If the directories
don't exist yet, you first need to to `cvs add path` and `cvs add path/to`.

The trickier part is for the committer then to make sure to not miss files
or directories...

> 
> On Wed, 2024-07-03 at 18:31 -0400, Josh Grosse wrote:
> > On Wed, Jul 03, 2024 at 02:48:28PM -0400, Jag Talon wrote:
> > > ah i reconfigured my editor and it should have less whitespace now
> > > :)
> > > 
> > > i added the revision as well thank you. OK?
> > 
> > I've got some minor changes to Jag's latest diff:
> > 
> > 1.  REVISION=0 as recommended by bsd.port.mk(5).
> > 2.  Two extra blank lines dropped from the Makefile.
> > 3.  This diff aslo creates files/tarsnap-gui.desktop.
> > 
> > OK maintainer, FWIW.
> > 
> > ------
> > 
> > diff --git a/sysutils/tarsnap-gui/Makefile b/sysutils/tarsnap-
> > gui/Makefile
> > index e569f5ac231..107c7b39645 100644
> > --- a/sysutils/tarsnap-gui/Makefile
> > +++ b/sysutils/tarsnap-gui/Makefile
> > @@ -3,6 +3,7 @@ COMMENT =		frontend to the popular
> > Tarsnap backup service
> >  GH_ACCOUNT =		Tarsnap
> >  GH_PROJECT =		tarsnap-gui
> >  GH_TAGNAME =		v1.0.2
> > +REVISION =		0
> >  
> >  CATEGORIES =		sysutils
> >  
> > @@ -15,9 +16,16 @@ WANTLIB += ${COMPILER_LIBCXX} GL Qt5Core Qt5Gui
> > Qt5Network Qt5Sql
> >  WANTLIB += Qt5Widgets c m
> >  
> >  MODULES =		devel/qmake x11/qt5
> > -RUN_DEPENDS =		sysutils/tarsnap
> > +RUN_DEPENDS =		sysutils/tarsnap \
> > +			devel/desktop-file-utils
> >  
> >  do-install:
> >  	${INSTALL_PROGRAM} ${WRKBUILD}/tarsnap-gui
> > ${PREFIX}/bin/tarsnap-gui
> > +	${INSTALL_DATA_DIR} ${PREFIX}/share/applications/
> > +	${INSTALL_DATA} ${FILESDIR}/tarsnap-gui.desktop \
> > +		${PREFIX}/share/applications/
> > +	${INSTALL_DATA_DIR} ${PREFIX}/share/pixmaps/
> > +	${INSTALL_DATA} ${WRKSRC}/resources/icons/tarsnap-icon-
> > big.png \
> > +		${PREFIX}/share/pixmaps/tarsnap-gui.png
> >  
> >  .include <bsd.port.mk>
> > diff --git a/sysutils/tarsnap-gui/files/tarsnap-gui.desktop
> > b/sysutils/tarsnap-gui/files/tarsnap-gui.desktop
> > new file mode 100644
> > index 00000000000..f4d230a770c
> > --- /dev/null
> > +++ b/sysutils/tarsnap-gui/files/tarsnap-gui.desktop
> > @@ -0,0 +1,9 @@
> > +[Desktop Entry]
> > +GenericName=Backup
> > +Name=Tarsnap Backup
> > +Comment=GUI for the Tarsnap backup service
> > +Exec=tarsnap-gui
> > +Terminal=false
> > +Type=Application
> > +Categories=Utility;Archiving;Qt;
> > +Icon=tarsnap-gui
> > diff --git a/sysutils/tarsnap-gui/pkg/PLIST b/sysutils/tarsnap-
> > gui/pkg/PLIST
> > index cde9a026acb..c3718603941 100644
> > --- a/sysutils/tarsnap-gui/pkg/PLIST
> > +++ b/sysutils/tarsnap-gui/pkg/PLIST
> > @@ -1,2 +1,6 @@
> >  @bin bin/tarsnap-gui
> > +share/applications/tarsnap-gui.desktop
> >  share/doc/pkg-readmes/${PKGSTEM}
> > +share/pixmaps/
> > +share/pixmaps/tarsnap-gui.png
> > +@tag update-desktop-database
> > 
>