From: Thomas Frohwein <tfrohwein@fastmail.com>
Subject: Re: [NEW] x11/contour (work-in-progress)
To: SASANO Takayoshi <uaa@mx5.nisiq.net>
Cc: ports@cvs.openbsd.org
Date: Sun, 7 Jul 2024 15:17:08 -0400

On Sun, Jul 07, 2024 at 03:01:56PM +0900, SASANO Takayoshi wrote:
> Hello,

Thanks, I got this all to build and was able to spawn a contour
terminal, but I think this needs some more work. The prerequisites
first:

> https://marc.info/?l=openbsd-ports&m=171961710727187&w=2 (libunicode)

- can leave out HOMEPAGE (automatically set by GH_*)
- can scratch first line of DESCR
- BUILD_DEPENDS on python - add lang/python to MODULES?:
[0/24] cd /usr/ports/pobj/libunicode-0.4.0/build-amd64 && /usr/local/bin/python3.11 /usr/ports/pobj/libunicode-0.4.0/libunicode-0.4.0/src/libunicode/mktables.py /usr/local/share/unicode/ucd
- take MAINTAINER?

> https://marc.info/?l=openbsd-ports&m=171961232324802&w=2 (boxed-cpp)

- use NO_BUILD = Yes and remove COMPILER line
- probably also PKG_ARCH=* as only a header file
- can scratch first line of DESCR
- take MAINTAINER?
- remove HOMEPAGE (automatically set by GH_*)

With DESCR adjusted, HOMEPAGE removed, python build dependency honored,
and NO_BUILD addressed, the ports libunicode and boxed-cpp are ok thfr@

> I am working x11/contour, contour-terminal (http://contour-terminal.org/).
> Here is the commit-4c71d0cce2e63a23859a1cf7b389dc9e872384a1 based ports,
> work-in-progress version.

I think this needs more work, especially addressing the issues with
port-lib-depends-check, portcheck, and make install, as well as picking
a clearer version number IMO. Here my notes on the contour port draft:

- superfluous '\' at the end of BUILD_DEPENDS
- take MAINTAINER?
- can leave out CONFIGURE_STYLE = cmake (set by module)
- last sentence in DESCR is more written like marketing than a description
- make port-lib-depends-check:
	Missing: crypto.54 (/usr/local/bin/contour) (system lib)
	Missing lib: ssh2.10 (/usr/local/bin/contour) (NOT REACHABLE)
	Missing: ssl.57 (/usr/local/bin/contour) (system lib)
	WANTLIB += crypto ssl
=> also LIB_DEPENDS on security/libssh2
- portcheck:
	no leading articles in COMMENT, please
	missing RUN_DEPENDS+=x11/gtk+4,-guic
	missing RUN_DEPENDS+=devel/desktop-file-utils
- I suggest: COMMENT=modern & fast terminal emulator
- make install:
Error in file "/usr/local/share/applications/org.contourterminal.Contour.desktop": "" is an invalid MIME type ("" does not contain a subtype)