From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: security/vpnc: dhclient -> ifconfig inet autoconf
To: Klemens Nanni <kn@openbsd.org>, <ports@openbsd.org>
Date: Fri, 12 Jul 2024 10:00:51 +0100

This change won't work directly as the following lines currently need 
blocking until dhcp has fetched an address but I don't think it's worth it. 
For some ports it makes sense to keep them anyway when they're 
unmaintained, but a VPN client not updated since ~2008 with "Supports only
shared-secret IPSec authentication with Xauth,
AES (256, 192, 128), 3DES, 1DES, MD5, SHA1,
DH1/2/5" ... I would just remove the port as 'unmaintained upstream' (which 
is ok sthen).

-- 
  Sent from a phone, apologies for poor formatting.

On 11 July 2024 18:19:03 Klemens Nanni <kn@openbsd.org> wrote:

> Not a user of this, but this port is now obviously broken after dhclient 
> removal.
> `dhclient ifN` has already been `ifconfig ifN inet autoconf' for years, so 
> do that.
>
> Neither blocks or guarantees that we actually get an IP, but that's 
> apparently hasn't
> been a problemm in so far as noone bothered to patch/fix this port.
>
> Is anyone actually using this?
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/security/vpnc/Makefile,v
> diff -u -p -r1.29 Makefile
> --- Makefile	27 Sep 2023 16:34:38 -0000	1.29
> +++ Makefile	6 Jul 2024 08:38:32 -0000
> @@ -1,7 +1,7 @@
> COMMENT=		client for Cisco 3000 VPN concentrators
>
> DISTNAME=		vpnc-0.5.3
> -REVISION=		6
> +REVISION=		7
> CATEGORIES=		security net
>
> HOMEPAGE=		http://www.unix-ag.uni-kl.de/~massar/vpnc/
> Index: files/vpnc.sh
> ===================================================================
> RCS file: /cvs/ports/security/vpnc/files/vpnc.sh,v
> diff -u -p -r1.5 vpnc.sh
> --- files/vpnc.sh	11 Mar 2022 19:54:08 -0000	1.5
> +++ files/vpnc.sh	11 Jul 2024 17:12:16 -0000
> @@ -6,7 +6,7 @@ VPNGATEWAY=192.168.0.1
>
> case "$1" in
> start)
> -	dhclient ${PHYS_IF}
> +	ifconfig ${PHYS_IF} inet autoconf
> 	DEFAULTROUTER=`route -n show -inet | grep default | awk '{ print $2 }'`
> 	${PREFIX}/sbin/vpnc || exit 1
> 	TUN_IP=`ifconfig ${TUN_IF} | grep netmask | awk '{ print $2 }'`
> @@ -17,7 +17,7 @@ start)
> stop)
> 	route delete -host ${VPNGATEWAY}
> 	pkill vpnc
> -	pkill "dhclient ${PHYS_IF}"
> +	ifconfig ${PHYS_IF} inet -autoconf
> 	ifconfig ${PHYS_IF} down
> 	;;
> *)