From: Omar Polo <op@omarpolo.com>
Subject: Re: NEW: devel/lua-lpty
To: ASOU Masato <takeasou.masato@gmail.com>
Cc: ports@openbsd.org
Date: Sat, 13 Jul 2024 15:48:44 +0200

ASOU Masato <takeasou.masato@gmail.com> wrote:
> Hi ports@,
> 
> I want to import devel/lua-lpty into the tree.
> 
> DESCR:
> lpty is a module that allows a program written in lua to open the master side of
> a PTY and start a program with the slave side of the PTY as its controlling
> terminal.  The PTY may then be read from and written to, thus controlling the
> remote program.
> 
> lpty is released under the terms of the MIT license.
> 
> If you have anything to say about this, comments, bug reports,
> whatever, feel free
> to email them to gz@tset.de
> 
> ok, comments?

A few nits:

 - for new ports, please send a tarball
 - the patch is mangled and doesn't apply.
 - REVISION starts empty (i.e. no REVISION at all)
 - why only for lua 5.1?  using flavors we can provide this for all lua
   versions.
 - the distname has a name that's too generic ("version_${V}").  This
   can be a problem because it may clash with another port' distname.
   I'd use DISTFILES with the {} syntax to rename the file (see
   bsd.port.mk and grep for `minetest')
 - no need to patch the Makefile, we can use MAKE_FLAGS to override the
   variables.
 - I'd reflow the DESCR and drop the mention of the license and the
   upstream email address.
 - `make update-plist' adds the @so marker

I'm attaching a tarball with above fixed that's OK op@ to import if it
works for you, I haven't tested it at runtime.


Thanks,

Omar Polo