From: Jag Talon <jag@aangat.lahat.computer>
Subject: Re: [new] multimedia/mat2
To: ports@openbsd.org
Date: Wed, 17 Jul 2024 09:51:49 -0400

Ping! Does this look ok to everyone?

On Tue, 2024-07-09 at 19:02 -0400, Jag Talon wrote:
> Ah thank you for that yes I removed the mention of the file manager
> extensions (perhaps I can add that back in the future by pulling in
> 0xacab.org directly and installing the Dolphin extension), applied
> the
> diff, and also cleaned up the tarball.
> 
> OK?
> 
> On 7/9/24 10:10 AM, Stuart Henderson wrote:
> > On 2024/07/09 08:55, Jag Talon wrote:
> > > Thank you for the feedback. Fixed the issues and added a list of
> > > supported file formats from
> > > https://0xacab.org/jvoisin/mat2#supported-formats.
> > > 
> > > OK?
> > > 
> > > On 7/9/24 7:53 AM, Stuart Henderson wrote:
> > > > On 2024/07/09 07:47, Jag Talon wrote:
> > > > > Ping for review :)
> > > > > 
> > > > > On 6/25/24 11:31 PM, Jag Talon wrote:
> > > > > > adjusted Makefile to have a more accurate list of
> > > > > > LIB_DEPENDS and
> > > > > > RUN_DEPENDS
> > > > > > 
> > > > > > On 6/25/24 2:22 PM, Jag Talon wrote:
> > > > > > > added both the python library libmat2 and a command line
> > > > > > > tool called
> > > > > > > mat2 to remove metadata from various files.
> > > > > > > 
> > > > > > > https://0xacab.org/jvoisin/mat2
> > > > > > > 
> > > > > > > tests are disabled because the tarball in
> > > > > > > https://pypi.org/project/mat2/
> > > > > > > doesn't include the test documents.
> > > > > > > 
> > > > > > > the test documents are, however, present in
> > > > > > > https://0xacab.org/jvoisin/mat2 so cloning that
> > > > > > > repository separately
> > > > > > > and running the test yields the attached test-results.txt
> > > > > > > file. Looks
> > > > > > > like it fails on some video files which i'll look into,
> > > > > > > but it mostly
> > > > > > > works at least on my own personal files!
> > > > > > > 
> > > > > > > this library can be a building block for apps that use
> > > > > > > mat2 like
> > > > > > > https://gitlab.com/rmnvgr/metadata-cleaner as well.
> > > > > > > 
> > > > > > > the library also requires a couple runtime libraries to
> > > > > > > be installed,
> > > > > > > and they can be checked by running the --check-
> > > > > > > dependencies command.
> > > > > > > 
> > > > > > > $ mat2 --check-dependencies
> > > > > > > Dependencies for mat2 0.13.4:
> > > > > > > - Cairo: yes
> > > > > > > - Exiftool: yes (optional)
> > > > > > > - Ffmpeg: yes (optional)
> > > > > > > - GLib from PyGobject: yes
> > > > > > > - GdkPixbuf from PyGobject: yes
> > > > > > > - Mutagen: yes
> > > > > > > - Poppler from PyGobject: yes
> > > > > > > - PyGobject: yes
> > > > > > > 
> > > > > > > please test! works on my files on current/amd64. OK?
> > > > > > > 
> > > > > > 
> > > > > 
> > > > > -- 
> > > > > jagtalon.net
> > > > > weirder.earth/@jag
> > > > > 
> > > > 
> > > > From reading:
> > > > 
> > > > LIB_DEPENDS without associated WANTLIB entries are invalid.
> > > > You do not want any "LIB_DEPENDS xx not needed for" when you
> > > > run
> > > > "make package".
> > > > 
> > > > Python module dependencies should be RUN_DEPENDS (and possibly
> > > > in some cases also BUILD_DEPENDS), and should use
> > > > ${MODPY_FLAVOR}.
> > > > 
> > > > Trailing \ in LIB_DEPENDS.
> > > > 
> > > > I don't think it makes sense to put devel in CATEGORIES, and it
> > > > would be helpful to give a list of supported file formats in
> > > > DESCR.
> > > > 
> > > 
> > > -- 
> > > jagtalon.net
> > > weirder.earth/@jag
> > 
> > Some tweaks on top:
> > 
> > - more descriptive comment
> > - DESCR should be plain ASCII, not UTF-8
> > - simplify DESCR
> > 
> > I left "several file manager extensions" in DESCR for now, but they
> > don't actually seem to be included in the package, they should
> > either
> > be added or that should be dropped I think.
> > 
> > btw, it would be helpful if tars are generated with a directory
> > layout
> > like "category/port" or just "port", please don't include usr/ports
> > in the tar.
> > 
> > diff --git a/multimedia/py-mat2/Makefile b/multimedia/py-
> > mat2/Makefile
> > index 2cd5c5c..1ca63ca 100644
> > --- a/multimedia/py-mat2/Makefile
> > +++ b/multimedia/py-mat2/Makefile
> > @@ -1,4 +1,4 @@
> > -COMMENT =		handy tool to trash your metadata
> > +COMMENT =		remove metadata from media files
> >  
> >  MODPY_EGG_VERSION =	0.13.4
> >  DISTNAME =		mat2-${MODPY_EGG_VERSION}
> > diff --git a/multimedia/py-mat2/pkg/DESCR b/multimedia/py-
> > mat2/pkg/DESCR
> > index 4c0d05e..9178c45 100644
> > --- a/multimedia/py-mat2/pkg/DESCR
> > +++ b/multimedia/py-mat2/pkg/DESCR
> > @@ -1,8 +1,8 @@
> > -mat2 is a metadata removal tool, supporting a wide range of
> > commonly used file
> > -formats, written in python3: at its core, it's a library, used by
> > an eponymous
> > -command-line interface, as well as several file manager
> > extensions.
> > +mat2 is a metadata removal tool, supporting a wide range of
> > commonly
> > +used file formats. It provides a Python library, command-line
> > interface,
> > +as well as several file manager extensions.
> >  
> > -The following formats are supported: avi, bmp, css, epub/ncx,
> > flac, gif,
> > -jpeg, m4a/mp2/mp3/…, mp4, odc/odf/odg/odi/odp/ods/odt/…,
> > off/opus/oga/spx/…,
> > -pdf, png, ppm, pptx/xlsx/docx/…, svg/svgz/…,
> > tar/tar.gz/tar.bz2/tar.xz/…, tiff,
> > -torrent, wav, wmv, zip, …
> > +Supported formats include: avi, bmp, css, epub/ncx, flac, gif,
> > jpeg,
> > +m4a/mp2/mp3, mp4, odc/odf/odg/odi/odp/ods/odt, off/opus/oga/spx,
> > pdf,
> > +png, ppm, pptx/xlsx/docx, svg/svgz, tar/tar.gz/tar.bz2/tar.xz,
> > tiff,
> > +torrent, wav, wmv, zip, ...
> > 
>