From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: lang/pcbasic: add icon and desktop file
To: Jag Talon <jag@aangat.lahat.computer>
Cc: ports@openbsd.org, bcallah@openbsd.org, Theo Buehler <tb@theobuehler.org>
Date: Wed, 24 Jul 2024 12:36:22 +0100

On 2024/07/23 13:49, Jag Talon wrote:
> Apologies here is the diff and the png file attached I forgot to do
> that.

If you're sending out diffs for things like this, please don't make
unnecessary changes to the port. So in this case it would be the
additional RDEP, the post-install stages, and file additions.
Layout changes in the Makefile just make it hard to review (and
usually when a port has a maintainer, they have already done the
formatting in the way which they prefer).

> diff -N files/pcbasic.png
> Binary files /dev/null and pcbasic.png differ

Stuffing binary files in the ports tree is not ideal. It would be
better to fetch as a supplementary distfile if possible.
It would look something like: setting SITES.icon, DISTFILES.icon,
EXTRACT_ONLY=${GH_DISTFILE}, and copying from ${FULLDISTDIR}
rather than ${FILESDIR}.