From: Adriano Barbosa <barbosa.aob@gmail.com>
Subject: Re: nextcloudclient-3.13.2 requires kguiaddons
To: Rafael Sadowski <rafael@sizeofvoid.org>
Cc: Sven Wolf <mailinglist@fusion-zone.net>, ports <ports@openbsd.org>
Date: Mon, 29 Jul 2024 09:40:38 -0400

Hi,
Thank you for spotting this and for the diff.
It works for me and can be committed.

Obrigado!
—
Adriano

> Em 28 de jul. de 2024, à(s) 15:27, Rafael Sadowski <rafael@sizeofvoid.org> escreveu:
> 
> On Sun Jul 28, 2024 at 04:32:06PM GMT, Sven Wolf wrote:
>> Hi,
>> 
>> I'm on OpenBSD -current.
>> 
>> After the update of nextcloudclient to version 3.13.2 my nextcloudclient
>> stops with the error message:
>> ld.so: nextcloud: can't load library 'libKF5GuiAddons.so.7.0'
>> Killed
>> 
>> After I manually installed kguiaddons everything in fine again.
>> pkg_add -v kguiaddons
>> Update candidates: quirks-7.46 -> quirks-7.46
>> Direct dependencies for quirks-7.46->7.46 resolve to updatedb-0p0
>> quirks-7.46 signed on 2024-07-26T17:57:33Z
>> No change in quirks-7.46
>> parsing kguiaddons-5.116.0
>> Direct dependencies for kguiaddons-5.116.0 resolve to
>> desktop-file-utils-0.27 qtx11extras-5.15.13 qtwayland-5.15.13pl60
>> qtbase-5.15.13pl145 (todo: qtwayland-5.15.13pl60)
>> parsing qtwayland-5.15.13pl60
>> Direct dependencies for qtwayland-5.15.13pl60 resolve to wayland-1.22.0p0
>> qtdeclarative-5.15.13pl30 libxkbcommon-1.7.0 qtbase-5.15.13pl145
>> kguiaddons-5.116.0:qtwayland-5.15.13pl60: ok
>> Direct dependencies for kguiaddons-5.116.0 resolve to
>> desktop-file-utils-0.27 qtbase-5.15.13pl145 qtwayland-5.15.13pl60
>> qtx11extras-5.15.13
>> kguiaddons-5.116.0: ok
>> Running /sbin/ldconfig -R
>> define-tag /usr/local/bin/update-desktop-database
>> Running tags: ok
>> 
>> In my opinion kguiaddons should be added as a dependency to nextcloudclient.
>> 
>> Best regards,
>> Sven
>> 
> 
> Thank you, I can confirm this. Below you will find a diff with a new
> LIB_DEPENDS. Sorted and some more dependencies.
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/nextcloudclient/Makefile,v
> diff -u -p -r1.62 Makefile
> --- Makefile 13 Jul 2024 07:36:25 -0000 1.62
> +++ Makefile 28 Jul 2024 19:23:25 -0000
> @@ -4,6 +4,7 @@ COMMENT = desktop sync client for Nextcl
> 
> V = 3.13.2
> DISTNAME = nextcloudclient-${V}
> +REVISION = 0
> 
> GH_ACCOUNT = nextcloud
> GH_PROJECT = desktop
> @@ -22,12 +23,16 @@ MAINTAINER = Adriano Barbosa <barbosa.ao
> # GPLv2+
> PERMIT_PACKAGE = Yes
> 
> -WANTLIB += ${COMPILER_LIBCXX} lib/inotify/inotify KF5Archive
> -WANTLIB += Qt5Concurrent Qt5Core Qt5DBus Qt5Gui Qt5Network Qt5Positioning
> -WANTLIB += Qt5PrintSupport Qt5Qml Qt5QmlModels Qt5Quick Qt5QuickControls2
> -WANTLIB += Qt5Svg Qt5WebChannel Qt5WebEngineCore Qt5WebEngineWidgets
> -WANTLIB += Qt5WebSockets Qt5Widgets Qt5Xml c crypto m qt5keychain
> -WANTLIB += cloudproviders gio-2.0 glib-2.0 gobject-2.0 intl sqlite3 ssl z
> +WANTLIB += ${COMPILER_LIBCXX} KF5Archive KF5GuiAddons Qt5Concurrent
> +WANTLIB += Qt5Core Qt5DBus Qt5Gui Qt5Network Qt5Positioning Qt5PrintSupport
> +WANTLIB += Qt5Qml Qt5QmlModels Qt5Quick Qt5QuickControls2 Qt5QuickWidgets
> +WANTLIB += Qt5Sql Qt5Svg Qt5WebChannel Qt5WebEngineCore Qt5WebEngineWidgets
> +WANTLIB += Qt5WebSockets Qt5Widgets Qt5Xml c cloudproviders crypto
> +WANTLIB += gio-2.0 glib-2.0 gobject-2.0 intl m qt5keychain sqlite3
> +WANTLIB += ssl z
> +
> +WANTLIB += lib/inotify/inotify
> +
> 
> MODULES = devel/cmake \
> x11/qt5
> @@ -50,12 +55,16 @@ RUN_DEPENDS = devel/desktop-file-utils 
> x11/qt5/qtquickcontrols
> 
> LIB_DEPENDS = databases/sqlite3 \
> - devel/libinotify \
> devel/kf5/karchive \
> + devel/kf5/kguiaddons \
> + devel/libinotify \
> security/qtkeychain \
> x11/gnome/libcloudproviders \
> - x11/qt5/qtsvg \
> + x11/qt5/qtdeclarative \
> + x11/qt5/qtlocation \
> x11/qt5/qtquickcontrols2 \
> + x11/qt5/qtsvg \
> + x11/qt5/qtwebchannel \
> x11/qt5/qtwebengine \
> x11/qt5/qtwebsockets
>