From: Omar Polo Subject: Re: [Maintainer update] Add FLAVOR to emulator/minivmac To: Jag Talon Cc: Stuart Henderson , "Anthony J. Bentley" , ports@openbsd.org, George Koehler Date: Tue, 30 Jul 2024 18:31:14 +0200 On 2024/07/30 18:18:57 +0200, Omar Polo wrote: > On 2024/07/30 10:48:58 -0400, Jag Talon wrote: > > Attached is my attempt to do that, but when running `make install` it > > seems to install minivmac-36.04 but with the binary for minivmac-ii- > > 36.04. > > This due to how make evals the variables. You have > > : # Macintosh Plus > : MODEL = -m Plus > : > : # Macintosh II > : .if ${FLAVOR:Mii} > : MODEL = -m II > : SUFFIX = -ii > : .endif > > so MODEL will always be '-m II'. sorry, got the values swapped but I was talking trash anyway so discard this. using '=' in make overrides previous values, so model is set to '-m II' iff FLAVOR is ii. (yet, i believe using ?= or the conditionals is cleaner in these cases :P)