From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: [Maintainer update] Add FLAVOR to emulator/minivmac
To: Omar Polo <op@omarpolo.com>
Cc: Jag Talon <jag@aangat.lahat.computer>, ports@openbsd.org
Date: Tue, 6 Aug 2024 17:31:53 +0100

On 2024/08/06 15:31, Omar Polo wrote:
> 
> > +.if ${FLAVOR:Mplus}
> > +MODEL = 		-m Plus
> > +.elif ${FLAVOR:Mii}
> > +MODEL = 		-m II
> > +SUFFIX = 		-${FLAVOR}
> > +.endif
> 
> it's not strictly required, but I'd consider adding a .else part that
> throws an error to catch unsupported combinations.

would need .if ${FLAVOR} == rather than :M in that case

> For example, since flavors "stacks", it should be possible to build with
> both flavors, something that it's not supported.  So, i'd go with
> something along the lines of
> 
> 	[...]
> 	.else
> 	ERRORS += unsupported flavor ${FLAVOR}
> 	.endif
> 
> (maybe with a better verbiage)
> 
> > +FULLPKGNAME =		minivmac${SUFFIX}-${V}
> > +SUBST_VARS =		SUFFIX
> > +
> > [...]
> > --- pkg/DESCR	18 Jul 2024 01:58:15 -0000	1.1.1.1
> > +++ pkg/DESCR	5 Aug 2024 21:57:08 -0000
> > @@ -1 +1,6 @@
> > -Macintosh Plus emulator.
> > +Mini vMac is an emulator for computers that Apple sold from 1984 to 1996
> > +based on Motorola's 680x0 microprocessors. The default emulates the
> > +Macintosh Plus.
> > +
> > +Flavors:
> > +	ii	- Emulate the Macintosh II
> 
> regarding the flavors, if -plus has to stay here we should also list
> it i think?
> 
> 
> (there's also the thing about the hardcoded paths in the desktop files
> that could use ${TRUEPREFIX} + SUBST_DATA instead, but i think it's also
> fine like it is now)
>