From: Theo Buehler <tb@theobuehler.org>
Subject: Re: devel/abseil-cpp: update to 20240722.0 (bulk wanted)
To: Klemens Nanni <kn@openbsd.org>
Cc: ports <ports@openbsd.org>, Andrew Krasavin <noiseless-ak@yandex.ru>
Date: Wed, 7 Aug 2024 13:22:32 +0200

On Sun, Aug 04, 2024 at 08:49:39PM +0000, Klemens Nanni wrote:
> 04.08.2024 23:42, Klemens Nanni пишет:
> > https://github.com/abseil/abseil-cpp/releases
> > 
> > Simple update, same 'make test' results as with the current version:
> > 
> > 99% tests passed, 3 tests failed out of 213
> > 
> > Total Test time (real) = 232.63 sec
> > 
> > The following tests FAILED:
> > 	 97 - absl_log_stripping_test (Failed)
> > 	166 - absl_charconv_test (Failed)
> > 	174 - absl_str_format_convert_test (Failed)
> > 
> > 
> > There a few new libs and I reformatted the ABSL_LIBS block.
> > 
> > 
> > Would anyone be so kind and put this through a bulk?
> > I'm not expecting (much) fallout, but would like to know/fix things before.
> > 
> > My WIP net/tg_owt and net/tdesktop updates are happy with new abseil.
> 
> Same diff with a major crank which I forgot.

Doesn't build on sparc64. Not sure if that should be considered a
blocker.

[52/806] /usr/ports/pobj/abseil-cpp-20240722.0/bin/c++  -I/usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0 -I/googletest/include -I/googlemock/include -O2 -pipe -DNDEBUG -Wall -Wextra -Wcast-qual -Wconversion-null -Wformat-security -Wnon-virtual-dtor -Woverlength-strings -Wpointer-arith -Wundef -Wunused-local-typedefs -Wunused-result -Wvarargs -Wvla -Wwrite-strings -DNOMINMAX -Wno-deprecated-declarations -Wno-missing-declarations -Wno-self-move -Wno-sign-compare -Wno-unused-function -Wno-unused-parameter -Wno-unused-private-field -MD -MT absl/base/CMakeFiles/absl_low_level_alloc_test.dir/internal/low_level_alloc_test.cc.o -MF absl/base/CMakeFiles/absl_low_level_alloc_test.dir/internal/low_level_alloc_test.cc.o.d -o absl/base/CMakeFiles/absl_low_level_alloc_test.dir/internal/low_level_alloc_test.cc.o -c /usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/base/internal/low_level_alloc_test.cc
FAILED: absl/base/CMakeFiles/absl_low_level_alloc_test.dir/internal/low_level_alloc_test.cc.o
/usr/ports/pobj/abseil-cpp-20240722.0/bin/c++  -I/usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0 -I/googletest/include -I/googlemock/include -O2 -pipe -DNDEBUG -Wall -Wextra -Wcast-qual -Wconversion-null -Wformat-security -Wnon-virtual-dtor -Woverlength-strings -Wpointer-arith -Wundef -Wunused-local-typedefs -Wunused-result -Wvarargs -Wvla -Wwrite-strings -DNOMINMAX -Wno-deprecated-declarations -Wno-missing-declarations -Wno-self-move -Wno-sign-compare -Wno-unused-function -Wno-unused-parameter -Wno-unused-private-field -MD -MT absl/base/CMakeFiles/absl_low_level_alloc_test.dir/internal/low_level_alloc_test.cc.o -MF absl/base/CMakeFiles/absl_low_level_alloc_test.dir/internal/low_level_alloc_test.cc.o.d -o absl/base/CMakeFiles/absl_low_level_alloc_test.dir/internal/low_level_alloc_test.cc.o -c /usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/base/internal/low_level_alloc_test.cc
In file included from /usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/container/internal/raw_hash_set.h:213,
                 from /usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/container/internal/raw_hash_map.h:26,
                 from /usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/container/node_hash_map.h:51,
                 from /usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/base/internal/low_level_alloc_test.cc:28:
/usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/container/internal/raw_hash_set.h: In instantiation of 'static const absl::lts_20240722::container_internal::PolicyFunctions& absl::lts_20240722::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::GetPolicyFunctions() [with Policy = absl::lts_20240722::container_internal::NodeHashMapPolicy<int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>; Hash = absl::lts_20240722::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = std::allocator<std::pair<const int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc> >]':
/usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/container/internal/raw_hash_set.h:3825:68:   required from 'std::pair<absl::lts_20240722::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::lts_20240722::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::find_or_prepare_insert_non_soo(const K&) [with K = int; Policy = absl::lts_20240722::container_internal::NodeHashMapPolicy<int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>; Hash = absl::lts_20240722::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = std::allocator<std::pair<const int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc> >]'
/usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/container/internal/raw_hash_set.h:3887:46:   required from 'std::pair<absl::lts_20240722::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::lts_20240722::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::find_or_prepare_insert(const K&) [with K = int; Policy = absl::lts_20240722::container_internal::NodeHashMapPolicy<int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>; Hash = absl::lts_20240722::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = std::allocator<std::pair<const int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc> >]'
/usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/container/internal/raw_hash_map.h:212:10:   required from 'std::pair<typename absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::raw_hash_set::iterator, bool> absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::try_emplace_impl(K&&, Args&& ...) [with K = const int&; Args = {}; Policy = absl::lts_20240722::container_internal::NodeHashMapPolicy<int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>; Hash = absl::lts_20240722::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = std::allocator<std::pair<const int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc> >; typename absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::raw_hash_set::iterator = absl::lts_20240722::container_internal::raw_hash_set<absl::lts_20240722::container_internal::NodeHashMapPolicy<int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>, absl::lts_20240722::hash_internal::Hash<int>, std::equal_to<int>, std::allocator<std::pair<const int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>
> >::iterator]'
/usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/container/internal/raw_hash_map.h:141:59:   required from 'std::pair<typename absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::raw_hash_set::iterator, bool> absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::try_emplace(absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::key_arg<K>&, Args&& ...) [with K = int; Args = {}; typename std::enable_if<(! std::is_convertible<K, typename absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::raw_hash_set::const_iterator>::value), int>::type <anonymous> = 0; Policy = absl::lts_20240722::container_internal::NodeHashMapPolicy<int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>; Hash = absl::lts_20240722::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = std::allocator<std::pair<const int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc> >; typename absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::raw_hash_set::iterator = absl::lts_20240722::container_internal::raw_hash_set<absl::lts_20240722::container_internal::NodeHashMapPolicy<int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>, absl::lts_20240722::hash_internal::Hash<int>, std::equal_to<int>, std::allocator<std::pair<const int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc> > >::iterator; absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::key_arg<K> = int]'
/usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/container/internal/raw_hash_map.h:193:66:   required from 'absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::MappedReference<P> absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::operator[](absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::key_arg<K>&) [with K = int; P = absl::lts_20240722::container_internal::NodeHashMapPolicy<int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>; Policy = absl::lts_20240722::container_internal::NodeHashMapPolicy<int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>; Hash = absl::lts_20240722::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = std::allocator<std::pair<const int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc> >; absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::MappedReference<P> = absl::lts_20240722::base_internal::{anonymous}::BlockDesc&; typename absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::reference = std::pair<const int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>&; absl::lts_20240722::container_internal::raw_hash_map<Policy, Hash, Eq, Alloc>::key_arg<K> = int]'
/usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/base/internal/low_level_alloc_test.cc:119:22:   required from here
/usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/container/internal/raw_hash_set.h:4019:56:   in 'constexpr' expansion of 'absl::lts_20240722::container_internal::hash_policy_traits<absl::lts_20240722::container_internal::NodeHashMapPolicy<int, absl::lts_20240722::base_internal::{anonymous}::BlockDesc>, void>::get_hash_slot_fn<absl::lts_20240722::hash_internal::Hash<int> >()'
/usr/ports/pobj/abseil-cpp-20240722.0/abseil-cpp-20240722.0/absl/container/internal/hash_policy_traits.h:163:54: error: '(absl::lts_20240722::container_internal::TypeErasedDerefAndApplyToSlotFn<absl::lts_20240722::hash_internal::Hash<int>, int> == 0)' is not a constant expression
     return Policy::template get_hash_slot_fn<Hash>() == nullptr
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
cc1plus: warning: unrecognized command line option '-Wno-unused-private-field'
cc1plus: warning: unrecognized command line option '-Wno-self-move'
ninja: build stopped: subcommand failed.

*** Error 1 in . (/usr/ports/devel/cmake/cmake.port.mk:50 'do-build': @cd /usr/ports/pobj/abseil-cpp-20240722.0/build-sparc64 && exec /usr/b...)
*** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:3057 '/usr/ports/pobj/abseil-cpp-20240722.0/build-sparc64/.build_done': @cd /usr/...)
*** Error 2 in /usr/ports/devel/abseil-cpp (/usr/ports/infrastructure/mk/bsd.port.mk:2704 'all': @lock=abseil-cpp-20240722.0;  export _LOCKS...)