From: Klemens Nanni <kn@openbsd.org>
Subject: Re: UPDATE: intel-gmmlib intel-media-driver
To: Rafael Sadowski <rafael@sizeofvoid.org>, ports <ports@openbsd.org>
Cc: Antoine Jacoutot <ajacoutot@openbsd.org>
Date: Sat, 10 Aug 2024 22:19:42 +0000

02.08.2024 22:16, Rafael Sadowski пишет:
> Update intel-gmmlib to 22.3.20 and intel-media-driver to 24.2.5.
> 
> I had hoped that this version would fix my segment error in
> mos_gpucontext_specific_next as there was a note in the release notes:
> "Improved software stability by fixing potential segment fault issues
> for AV1/AVC/HEVC/MPEG2/VP9 decoding".
> 
> https://github.com/intel/media-driver/releases/tag/intel-media-24.2.5
> 
> So I just plugged it by checking the globalInst variable.
> 
> OK? Feedback?

OK kn

intel-media-driver runs git:
    215 if (NOT DEFINED GIT_COMMIT)
    216     execute_process(
    217         COMMAND git rev-parse --short HEAD
    218         OUTPUT_VARIABLE GIT_COMMIT
    219         OUTPUT_STRIP_TRAILING_WHITESPACE
    220         WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
    221     )
    222 endif()
    223 
    224 add_definitions(-DMEDIA_VERSION="${MEDIA_VERSION}")
    225 add_definitions(-DMEDIA_VERSION_DETAILS="${GIT_COMMIT}")

media_driver/linux/common/ddi/media_libva.h
73:#define DDI_CODEC_GEN_STR_VENDOR                   "Intel iHD driver for Intel(R) Gen Graphics - " MEDIA_VERSION " (" MEDIA_VERSION_DETAILS ")"

We might as well pass -DGIT_COMMIT=OpenBSD or whatever to a) not run
git unconditionally during build and b) provide a non-empty string.

Also:
$ make update-patches
*** Patch for media_softlet/agnostic/common/os/mos_utilities_next.cpp misses newline at end of file