From: Mikolaj Kucharski <mikolaj@kucharski.name>
Subject: salt: NameError: name 'rsa' is not defined
To: ports@openbsd.org
Date: Thu, 22 Aug 2024 08:46:17 +0000

Hi all.

I've noticed on multiple of my -current OpenBSD machines following error
in /var/log/salt/minion:

---8<---
2024-08-22 08:31:45,252 [salt.minion                                                 :284 ][CRITICAL][39203] Unexpected error while connecting to fde4:f456:48c2:13c0::1
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/salt/minion.py", line 1148, in _connect_minion
    yield minion.connect_master(failed=failed)
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/gen.py", line 1056, in run
    value = future.result()
            ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/concurrent.py", line 249, in result
    raise_exc_info(self._exc_info)
  File "<string>", line 4, in raise_exc_info
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/gen.py", line 1064, in run
    yielded = self.gen.throw(*exc_info)
              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/minion.py", line 1389, in connect_master
    master, self.pub_channel = yield self.eval_master(
                               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/gen.py", line 1056, in run
    value = future.result()
            ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/concurrent.py", line 249, in result
    raise_exc_info(self._exc_info)
  File "<string>", line 4, in raise_exc_info
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/gen.py", line 309, in wrapper
    yielded = next(result)
              ^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/minion.py", line 817, in eval_master
    pub_channel = salt.channel.client.AsyncPubChannel.factory(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/channel/client.py", line 392, in factory
    auth = salt.crypt.AsyncAuth(opts, io_loop=io_loop)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/crypt.py", line 601, in __new__
    auth.__singleton_init__(opts, io_loop=io_loop)
  File "/usr/local/lib/python3.11/site-packages/salt/crypt.py", line 637, in __singleton_init__
    self.get_keys()
  File "/usr/local/lib/python3.11/site-packages/salt/crypt.py", line 1003, in get_keys
    gen_keys(
  File "/usr/local/lib/python3.11/site-packages/salt/crypt.py", line 147, in gen_keys
    gen = rsa.generate_private_key(e, keysize)
          ^^^
NameError: name 'rsa' is not defined
2024-08-22 08:31:45,918 [salt.crypt                                                  :284 ][INFO    ][39203] Generating keys: /etc/salt/pki/minion
2024-08-22 08:31:45,919 [salt.minion                                                 :284 ][CRITICAL][39203] Unexpected error while connecting to fde4:f456:48c2:13c0::1
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/salt/minion.py", line 1148, in _connect_minion
    yield minion.connect_master(failed=failed)
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/gen.py", line 1056, in run
    value = future.result()
            ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/concurrent.py", line 249, in result
    raise_exc_info(self._exc_info)
  File "<string>", line 4, in raise_exc_info
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/gen.py", line 1064, in run
    yielded = self.gen.throw(*exc_info)
              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/minion.py", line 1389, in connect_master
    master, self.pub_channel = yield self.eval_master(
                               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/gen.py", line 1056, in run
    value = future.result()
            ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/concurrent.py", line 249, in result
    raise_exc_info(self._exc_info)
  File "<string>", line 4, in raise_exc_info
  File "/usr/local/lib/python3.11/site-packages/salt/ext/tornado/gen.py", line 309, in wrapper
    yielded = next(result)
              ^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/minion.py", line 817, in eval_master
    pub_channel = salt.channel.client.AsyncPubChannel.factory(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/channel/client.py", line 392, in factory
    auth = salt.crypt.AsyncAuth(opts, io_loop=io_loop)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/salt/crypt.py", line 601, in __new__
    auth.__singleton_init__(opts, io_loop=io_loop)
  File "/usr/local/lib/python3.11/site-packages/salt/crypt.py", line 637, in __singleton_init__
    self.get_keys()
  File "/usr/local/lib/python3.11/site-packages/salt/crypt.py", line 1003, in get_keys
    gen_keys(
  File "/usr/local/lib/python3.11/site-packages/salt/crypt.py", line 147, in gen_keys
    gen = rsa.generate_private_key(e, keysize)
          ^^^
NameError: name 'rsa' is not defined
2024-08-22 08:31:45,971 [salt.crypt                                                  :284 ][INFO    ][39203] Generating keys: /etc/salt/pki/minion
--->8---

Log file grows rapidly with above errors. I noticed this recently, so I
am not sure when this exactly started to happen.

Machines where in Salt for a while as a minion, so I am a bit suprised
why following directory doesn't have any keys:

minion# find /etc/salt/pki/ -ls
 26580    4 drwxr-xr-x    3 root     wheel         512 Aug 13 15:54 /etc/salt/pki/
 26581    4 drwx------    2 root     wheel         512 Aug 13 15:54 /etc/salt/pki/minion

minion# pkg_info -qI | grep salt
salt-3006.9

On Salt master above machine has key added almost one year ago:

master# ls -l /etc/salt/pki/master/minions/pce-0041.home.lan
-rw-r--r--  1 _salt  _salt  451 Nov 19  2023 /etc/salt/pki/master/minions/pce-0041.home.lan

master# pkg_info -qI | grep salt
salt-3006.7p0

-- 
Regards,
 Mikolaj