From: Ingo Feinerer <feinerer@logic.at>
Subject: Re: UPDATE: x11/lemonbar
To: Klemens Nanni <kn@openbsd.org>
Cc: ports@openbsd.org
Date: Sun, 25 Aug 2024 13:01:05 +0200

On Sun, Aug 25, 2024 at 10:13:22AM +0000, Klemens Nanni wrote:
> 25.08.2024 09:41, Ingo Feinerer пишет:
> > Hi,
> > 
> > update x11/lemonbar 1.4 -> 1.5
> > 
> > - Upstream now has pledge() but uses err() which is undeclared.
> >   So keep and modify the patch.
> > 
> > - Drop MAINTAINER.
> > 
> > OK?
> 
> No lemonbar user, but...
> 
> > +@@ -1457,7 +1457,8 @@ main (int argc, char **argv)
> > + 
> > + #ifdef __OpenBSD__
> > +     if (pledge("stdio rpath", NULL) < 0) {
> > +-        err(EXIT_FAILURE, "pledge failed");
> > ++        fprintf(stderr, "pledge failed\n");
> > ++        exit(EXIT_FAILURE);
> 
> You ignore errno here.
> 
> You can also #include <err.h> and leave the code as-is;
> probably depends on upstream style, but either way, errno must not be lost.

Good point. I will just #include <err.h> and let upstream do what they do.
Thank you kn@ and op@!

> > +     }
> > + #endif
> >   
> > -     for (;;) {
> > -         bool redraw = false;
> > 
>