From: David Uhden Collado <david@uhden.dev>
Subject: Re: Upgrade to 2.53.1 and add FLAVOR to the net/i2pd port
To: tb@theobuehler.org
Cc: ports@openbsd.org, openbsd@systemfailure.net
Date: Thu, 29 Aug 2024 23:02:09 +0200

> I have committed the diff for 2.53.1 to -current without adding the
> flavor so that we can backport that if needed. However, I didn't see
> anything security related in the change log, so I did not do that.
> 

Thanks for your help!

> I'm pretty sure we should not add a new flavor to -stable.

I'm fine with that, in fact it looks like version 7.6 is just around the 
corner, so I don't see the need to change the port on -stable. My 
intention when I proposed these changes was to try to get them added to 
-current, and not to -stable.

> 
> If you want the upnp flavor in -current, please resend the diff, but
> that will need a proper ok.

Sure, here is the diff for the flavor I proposed for the net/i2pd port. 
There is no need to create another PLIST file, because no new files are 
added with this flavor.
Index: ports/net/i2pd/Makefile
===================================================================
RCS file: /cvs/ports/net/i2pd/Makefile,v
retrieving revision 1.25
diff -u -p -u -r1.25 Makefile
--- ports/net/i2pd/Makefile	29 Aug 2024 15:49:13 -0000	1.25
+++ ports/net/i2pd/Makefile	29 Aug 2024 20:51:16 -0000
@@ -18,6 +18,15 @@ COMPILER =	base-clang ports-gcc
 MODULES =	devel/cmake
 LIB_DEPENDS =	devel/boost
 
+FLAVORS+=upnp
+FLAVOR?=
+
+.if ${FLAVOR:Mupnp}
+WANTLIB +=	miniupnpc
+LIB_DEPENDS +=	net/miniupnp/miniupnpc
+CONFIGURE_ARGS +=	-DWITH_UPNP=ON
+.endif
+
 # for tests
 USE_GMAKE =	Yes