From: Edd Barrett Subject: Re: UPDATE: net/crawley-v1.7.8 To: Russ Sharek Cc: Antoine Jacoutot , ports@openbsd.org Date: Fri, 30 Aug 2024 15:23:19 +0100 On Thu, Aug 29, 2024 at 10:11:40PM -0400, Russ Sharek wrote: > I could use some input and guidance on how to handle the do-install: > thing Edd mentioned. Currently, the port passes all tests with the > MODGO_TEST_TARGET which was previously added. Instead of setting MODGO_TEST_TARGET, it would be more ports-idiomatic/clearer to use a `do-test` target like: ``` do-test: cd ${WRKSRC} && CGO_ENABLED=1 ${MODGO_CMD} test -count 1 -v \ -tags=test -coverprofile="cover.out" ./... ``` Tests are passing like this, so if you are alright with it, I think we can commit this. Cheers -- Best Regards Edd Barrett https://www.theunixzoo.co.uk