From: Jeremie Courreges-Anglas Subject: Re: Upgrade to 2.53.1 and add FLAVOR to the net/i2pd port To: Theo Buehler Cc: David Uhden Collado , Stuart Henderson , ports@openbsd.org, openbsd@systemfailure.net Date: Fri, 30 Aug 2024 20:56:49 +0200 On Fri, Aug 30, 2024 at 05:55:59PM +0200, Theo Buehler wrote: > On Fri, Aug 30, 2024 at 05:55:20PM +0200, David Uhden Collado wrote: > > > > I prefer to keep UPnP support as a flavor to avoid installing unnecessary > > > > dependencies for users who do not need this functionality. > > > > > > we don't generally do that in ports, it increases the burden on people > > > testing an update diff because then they need to check both versions > > > > > > if it doesn't change the behaviour unless a setting is also changed, > > > we would usually not add a flavour > > > > > > > Thank you for informing me. I'm new to porting software to OpenBSD and still > > learning the common practices. If this option doesn't alter the software's > > behavior, would it be possible to apply Jeremie Courreges-Anglas's diff? > > ok tb Committed, thanks. -- jca