From: Jeremie Courreges-Anglas <jca@wxcvbn.org>
Subject: Re: multimedia/gstreamer1/plugins-good on base-gcc archs
To: Brad Smith <brad@comstyle.com>
Cc: ajacoutot@openbsd.org, ports@openbsd.org, kmos@openbsd.org
Date: Mon, 2 Sep 2024 13:12:52 +0200

On Mon, Sep 02, 2024 at 03:35:02AM -0400, Brad Smith wrote:
> On 2024-09-02 3:32 a.m., Brad Smith wrote:
> > On 2024-09-02 3:28 a.m., Jeremie Courreges-Anglas wrote:
> > > The diff below lets me build multimedia/gstreamer1/plugins-good on
> > > sparc64.  The meson log shows attempts to use C++:
> > > 
> > > http://build-failures.rhaalovely.net/sparc64/2024-08-14/multimedia/gstreamer1/plugins-good.log
> > > 
> > > ok?
> > 
> > It already does this just a few lines above where your diff is.
> 
> The last commit was..
> 
> plugins-good actually uses C++, so we need to override the COMPILER_LANGS
> set in ../Makefile.inc
> 
> Fixes build on sparc64

Pfff, thanks for the pointer and sorry for the noise.

> > > 
> > > Index: Makefile
> > > ===================================================================
> > > RCS file:
> > > /home/cvs/repo/ports/multimedia/gstreamer1/plugins-good/Makefile,v
> > > diff -u -p -r1.86 Makefile
> > > --- Makefile    11 Jul 2024 09:53:58 -0000    1.86
> > > +++ Makefile    29 Jul 2024 15:14:27 -0000
> > > @@ -17,6 +17,7 @@ WANTLIB += gsttag-1.0 gstvideo-1.0 gtk-3
> > >   WANTLIB += opencore-amrnb opencore-amrwb orc-0.4 png shout speex
> > >   WANTLIB += tag twolame v4l2 vpx wavpack xml2 z
> > >   +COMPILER_LANGS=        c c++
> > >   LIB_DEPENDS=        ${P}/plugins-base=${V} \
> > >               archivers/bzip2 \
> > >               audio/flac \
> > > 
> > 
> 

-- 
jca