From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: [patch] neomutt: enable pcre2 to parse non-ASCII urls
To: James Cook <falsifian@falsifian.org>
Cc: ports@openbsd.org
Date: Tue, 3 Sep 2024 10:11:23 +0100

thanks, committed.

On 2024/09/03 04:57, James Cook wrote:
> On Tue, Jul 16, 2024 at 04:11:42PM +0000, James Cook wrote:
> > Hi,
> > 
> > neomutt can't properly parse non-ASCII URLs on OpenBSD without
> > pcre2. It doesn't affect me personally but I imagine someone out
> > there will be unhappy that neomutt can't open their IMAP folder.
> > See:
> > 
> > 	https://github.com/neomutt/neomutt/issues/4352
> > 
> > You can see it in neomutt by pressing "c" for the "change-folder"
> > command, then entering this URL from neomutt's test_url_parse():
> > 
> > 	imaps://foobar@gmail.com@imap.gmail.com/Отправленные
> > 
> > Currently, URL parsing fails and neomutt just silently takes you
> > to an empty index showing "(no mailbox)". With the below patch it
> > shows some login failures first. (I don't have any real non-ASCII
> > mailboxes to test it out on.)
> > 
> > I also removed the --idn=0 configure option. It seems to have become
> > a no-op in commit 707e03e3.
> > 
> > -- 
> > James
> 
> ping
> 
> 
> diff /usr/ports
> commit - 69e51b5b54a5eaf011a238d8566e08ade3de75eb
> path + /usr/ports
> blob - 10a691427f6899573b95320b0caf7aabfbfbd127
> file + mail/neomutt/Makefile
> --- mail/neomutt/Makefile
> +++ mail/neomutt/Makefile
> @@ -3,6 +3,7 @@ COMMENT=	tty-based e-mail client, forked from Mutt
>  GH_ACCOUNT=	neomutt
>  GH_PROJECT=	neomutt
>  GH_TAGNAME=	20240425
> +REVISION=	0
>  CATEGORIES=	mail
>  HOMEPAGE=	https://neomutt.org/
> @@ -15,11 +16,12 @@ PERMIT_PACKAGE=	Yes
>  COMPILER=	base-clang ports-gcc
>  # uses pledge()
> -WANTLIB+=	c crypto curses iconv idn2 intl ssl tdb z
> +WANTLIB+=	c crypto curses iconv idn2 intl pcre2-8 ssl tdb z
>  LIB_DEPENDS+=	databases/tdb \
>  		devel/gettext,-runtime \
> -		devel/libidn2
> +		devel/libidn2 \
> +		devel/pcre2
>  BUILD_DEPENDS+=	devel/gettext,-tools \
>  		lang/jimtcl \
>  		textproc/docbook-xsl \
> @@ -35,9 +37,9 @@ CONFIGURE_ARGS+= --mandir="${PREFIX}/man" \
>  		--with-ui=ncurses \
>  		--docdir="${PREFIX}/share/doc/neomutt" \
>  		--with-lock=flock \
> -		--idn=0 \
>  		--idn2 \
>  		--fmemopen \
> +		--pcre2 \
>  		--ssl \
>  		--tdb \
>  		--debug
>