From: Theo Buehler <tb@theobuehler.org>
Subject: Re: update: shells/nsh 1.2.2
To: ports@openbsd.org
Date: Fri, 6 Sep 2024 15:16:44 +0200

On Fri, Sep 06, 2024 at 02:04:58PM +0100, Stuart Henderson wrote:
> On 2024/09/06 14:00, Stuart Henderson wrote:
> > ===>  Faking installation for nsh-1.2.2
> > install -c -s  -o root -g bin  -m 755 nsh /pobj/nsh-1.2.2/fake-amd64/usr/local/bin/nsh
> > test -e /usr/local/bin/save.sh || install -m 755 -o root -g bin  /usr/obj/ports/nsh-1.2.2/nsh-1.2.2/save-rw.sh /usr/local/bin/save.sh
> > install: /usr/local/bin/INS@XIeCpSEu4i: Permission denied
> > *** Error 1 in /usr/obj/ports/nsh-1.2.2/nsh-1.2.2 (Makefile:63 'afterinstall')
> 
> This fixes it:
> 
> -FAKE_FLAGS =   PREFIX=${TRUEPREFIX}
> +FAKE_FLAGS =   DESTDIR=
> 

I ran into the same. It looks like stsp didn't hit it because there was
a /usr/local/bin/save.sh on the system.

With sthen's diff, both flavors build & package on sparc64.

Something isn't quite right with the plist or the post-install.
You sample save.sh, but if you regen the plist, you get another
save.sh which then breaks packaging. Should the post-install
target not have an 'rm ${PREFIX}/bin/save.sh'?