From: Neel chakraborty Subject: Re: New port Zoxide-v0.9.4 To: Neel chakraborty , A Tammy , ports@openbsd.org Date: Thu, 12 Sep 2024 09:41:16 +0530 On Wed, Sep 11, 2024 at 11:09 PM Stuart Henderson wrote: > On 2024/09/11 19:49, Neel chakraborty wrote: > > zoxide doesn't seem to very well support ksh, which is the default > shell and the one used > > by most developers in openbsd. > > > > Can you please let me know the problems you're having with running > zoxide on ksh? On my PC it > > works just fine. > > > > Here's my .kshrc > > eval "$(zoxide init posix --hook prompt)" > > > > Here is my .profile > > # $OpenBSD: dot.profile,v 1.8 2022/08/10 07:40:37 tb Exp $ > > # > > # sh/ksh initialization > > > > > PATH=$HOME/bin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/X11R6/bin:/usr/local/bin:/usr/local/sbin > > export PATH HOME TERM > > export ENV=$HOME/.kshrc > > > > > > One of the prerequisites for adding a port to openbsd is that there > should be enough > > interest by a developer who will likely have to do the testing, > maintenance and fixes when > > there are changes to the ports. > > > > I understand. Thanks for taking your time to go through my port, it > means a lot. > > > > On Wed, Sep 11, 2024 at 9:38 AM A Tammy wrote: > > > > > > > > On 9/10/24 3:16 AM, Neel chakraborty wrote: > > > > > > > > On Tue, Sep 10, 2024 at 11:54 AM Stuart Henderson < > stu@spacehopper.org> wrote: > > > > On 2024/09/09 23:00, aisha wrote: > > > On 24/09/09 10:26PM, Neel chakraborty wrote: > > > COMMENT = zoxide is a smarter cd command > > > > > > > comment should not end with "." > > > > it shouldn't repeat the name of the package either. > > > > keeping the same basic description, just "smarter cd > command" would be > > more like the usual style for COMMENT, but it would be > better to briefly > > explain what it does than use the word "smarter" which is > really unclear > > (and subjective). > > > > maybe something like "replacement for cd with history > searching"? > > > > > post-install: > > > ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide.1 > ${PREFIX}/man/man1/ > > > ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-add.1 > ${PREFIX}/man/man1/ > > > ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-import.1 > ${PREFIX}/man/man1/ > > > ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-init.1 > ${PREFIX}/man/man1/ > > > ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-query.1 > ${PREFIX}/man/man1/ > > > ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-remove.1 > ${PREFIX}/man/man1/ > > > > why not just "${INSTALL_MAN} ${WRKSRC}/man/man1/*.1 > ${PREFIX}/man/man1/"? > > more efficient and doesn't need changing if another page is > added in a > > future version. > > > > > > Thank you Stuart for your feedback, I have made the relevant > changes to the Makefile. > > Fix attached. > > > > > > Not to be a bummer, but it is unlikely that this particular port is > going to be added > > anytime soon. > > > > One, because we are close to release and aren't keen on adding new > ports right now and two > > because zoxide doesn't seem to very well support ksh, which is the > default shell and the > > one used by most developers in openbsd. > > > > One of the prerequisites for adding a port to openbsd is that there > should be enough > > interest by a developer who will likely have to do the testing, > maintenance and fixes when > > there are changes to the ports. > > > > I don't remember what problems I had when I tried it before, only > that I gave up on it. I've just tried your port and it does work here. However I would suggest > changing MESSAGE. Currently it points at a github webpage which is a > pain to read in console browsers, but also, it's not that unusual for > github to get blocked in various countries at various times, so relying > on it for important information about how to use the port isn't ideal. > > I was going to suggest a pkg/README file with the commands instead, but > actually the necessary info is in zoxide-init(1) so perhaps just kee > it in MESSAGE and refer to that instead. > > I think it may also be worth adding fzf as RUN_DEPENDS where it's > available (only on archs with go - which are fewer than those with > rust); that could be done with > > .include > .if ${PROPERTIES:Mgo} > RUN_DEPENDS += sysutils/fzf > .endif > Thanks for the feedback Stuart. I have implemented the recommended changes. zoxide-v0.9.4 attached.