From: Rafael Sadowski <rafael@sizeofvoid.org>
Subject: Re: [wip] devel/{pyside6,pyside6-tools,shiboken6}
To: ports <ports@openbsd.org>
Cc: Johannes Thyssen Tishman <johannes@thyssentishman.com>
Date: Fri, 25 Oct 2024 15:21:56 +0200

Please find attached a new tarball after the Qt 6.7.3 upgrade.

Could someone PLEASE review it and give an OK to import?

Index: Makefile.version
===================================================================
RCS file: /cvs/ports/x11/qt6/Makefile.version,v
diff -u -p -r1.14 Makefile.version
--- Makefile.version	24 Oct 2024 09:02:35 -0000	1.14
+++ Makefile.version	25 Oct 2024 13:14:36 -0000
@@ -1,5 +1,6 @@
 # Common source for Qt6 version
 QT6_VERSION =		6.7.3
+PYSIDE_VERSION =	6.7.3
 
 # This one is used for building dependencies for examples and documentation,
 # which obviously should be in sync with core packages.

On Thu Aug 29, 2024 at 03:37:45PM +0200, Johannes Thyssen Tishman wrote:
> Another friendly ping :) Last tarball attached.
> 
> 2024-07-07T10:05:06Z Johannes Thyssen Tishman:
> > Ping :)
> >
> > 2024-06-18T19:06:19Z Rafael Sadowski <rafael@sizeofvoid.org>:
> >
> > > Ping
> > >
> > > On Mon Jun 10, 2024 at 08:29:35AM GMT, Rafael Sadowski wrote:
> > >> On Sun Jun 02, 2024 at 09:56:56PM GMT, Johannes Thyssen Tishman wrote:
> > >>> 2024-06-02T08:43:11Z "Rafael Sadowski" <rafael@sizeofvoid.org>:
> > >>>> Hi Johannes, Hi ports@
> > >>>>
> > >>>> thanks for your hard work on PySide6. It was a good starting point 
> > >>>> for
> > >>>> me. (I took the latest tarball)
> > >>>
> > >>> Hi Rafael. Thank you for finishing this port :)
> > >>>
> > >>>> First of all, what have I done:
> > >>>>
> > >>>> - I moved pyside6 into x11/qt6. I would like to have it closely with 
> > >>>> Qt6
> > >>>>   so that we can update it together.
> > >>>> - Update to 6.6.2. Unfortunately, there was never a 6.6.3
> > >>>> - I moved all tools into bin/pyside6/* Idea from FeeBSD (as you 
> > >>>> already mentioned):
> > >>>>   
> > >>>> https://github.com/freebsd/freebsd-ports/blob/main/devel/pyside6-tools/Makefile#L35
> > >>>> - I've left you as a MAINTAINER. Is that okay with you?
> > >>>
> > >>> Of course, you have enough on your plate already. I'll do my best to
> > >>> maintain these.
> > >>
> > >> +1
> > >>
> > >>>
> > >>>> - BUILD_TESTS=OFF It's broken FreeBSD and Archlinux also disabled 
> > >>>> it.
> > >>>> - ${MODPY_COMPILEALL} from sthen@
> > >>>>
> > >>>> Feedback, OKs to import welcome.
> > >>>
> > >>> x11/qt6/pyside6/pyside depends on x11/qt6/qtgraphs which I couldn't 
> > >>> find
> > >>> in ports. I assume it's a WIP and you will import it? I tried 
> > >>> building
> > >>> without it (after installing shiboken) and it built and installed 
> > >>> fine.
> > >>
> > >> Yes, I sent x11/qt6/qtgraphs to ports@.
> > >>
> > >>>
> > >>> x11/qt6/pyside6/{shiboken,tools} built and installed fine without any
> > >>> more than the known issue you described (clang.8 not reachable).
> > >>>
> > >>> I noticed that all three ports make a debug-* package. Is this 
> > >>> intended?
> > >>>
> > >>> ...and one more nit below. Thanks again for your help Rafael.
> > >>>
> > >>> --- pyside/Makefile.orig    Sun Jun  2 23:54:03 2024
> > >>> +++ pyside/Makefile Sun Jun  2 23:54:07 2024
> > >>> @@ -47,7 +47,7 @@ LIB_DEPENDS = x11/qt6/pyside6/shiboken \
> > >>>         x11/qt6/qtsvg \
> > >>>         x11/qt6/qtwebchannel \
> > >>>         x11/qt6/qtwebengine \
> > >>> -       x11/qt6/qtwebsockets \
> > >>> +       x11/qt6/qtwebsockets
> > >>
> > >> Tahnks and fixed in new tarball, attached.
> > >>
> > >>>
> > >>> RUN_DEPENDS =      graphics/vulkan-headers
> > >>>
> > >>>
> > >>
> > >> Is anyone willing to look at this and give an OK to import?
>