From: <robin@tilde.institute>
Subject: graphics/feh files in conflict with the manpage
To: ports@openbsd.org
Cc: bcallah@openbsd.org
Date: Mon, 28 Oct 2024 10:59:42 +0000

Hi,

When installing feh, four files are put in /etc/feh/. They are examples 
files. Two of them (buttons and keys) are in conflict with feh's 
manpage:
- buttons, for example, change the zoom's binding from middle mouse 
button to right mouse button;
- keys, for example, change the meaning of the f key from toggle 
fullscreen to, in the same file, toggle filenames and then zoom in.

This files can also be found under /usr/local/share/examples/feh/. They 
are useful to learn how to write our own keys or mouse bindings. I 
think they are not meant to replace the default bindings. I suggest to 
remove them from /etc/feh/.

Two examples' files are left in /etc/feh/:
- find-lowres is a script shell that can be launched by typing its name;
- themes is a way to launch multiple feh options at the same time under 
an alias 
(feh -Tpresent means feh --full-screen --sort name --hide-pointer).

I don't think find-lowres is useful in /etc/feh/ but it doesn't seem to 
do any harm there; themes may already be used by several people and can 
be left there.

Below is a proposed diff to at least remove buttons and keys from 
/etc/feh/ to avoid conflicts with the manpage.
These files are in /etc/feh/ since -r1.6 (keys and themes), -r1.8 
(buttons) and -r1.11 (find-lowres). So quite a while. Maybe people are 
used to these bindings and don't mind them.

All the best,
Robin

Index: PLIST
===================================================================
RCS file: /cvs/ports/graphics/feh/pkg/PLIST,v
diff -u -p -c -r1.18 PLIST
*** PLIST	11 Mar 2022 19:22:17 -0000	1.18
--- PLIST	28 Oct 2024 10:04:57 -0000
*************** share/doc/feh/TODO
*** 9,19 ****
  share/examples/feh/
  @sample ${SYSCONFDIR}/feh/
  share/examples/feh/buttons
- @sample ${SYSCONFDIR}/feh/buttons
  share/examples/feh/find-lowres
  @sample ${SYSCONFDIR}/feh/find-lowres
  share/examples/feh/keys
- @sample ${SYSCONFDIR}/feh/keys
  share/examples/feh/themes
  @sample ${SYSCONFDIR}/feh/themes
  share/feh/
--- 9,17 ----