From: Landry Breuil <landry@openbsd.org>
Subject: fix portcheck false positive about files not being installed in icons subdir
To: ports@openbsd.org
Date: Fri, 1 Nov 2024 09:49:40 +0100

hi,

i never use portcheck, but i've been told this report on
elementary-xfce-icon-theme which is obviously a false positive for me:

$/usr/ports/infrastructure/bin/portcheck
installs icon AUTHORS in share/icons/elementary-xfce-dark, it should go in share/elementary-xfce-dark/icons/ or like instead
installs icon CONTRIBUTORS in share/icons/elementary-xfce-dark, it should go in share/elementary-xfce-dark/icons/ or like instead
installs icon LICENSE in share/icons/elementary-xfce-dark, it should go in share/elementary-xfce-dark/icons/ or like instead
installs icon README.md in share/icons/elementary-xfce-dark, it should go in share/elementary-xfce-dark/icons/ or like instead
installs icon AUTHORS in share/icons/elementary-xfce, it should go in share/elementary-xfce/icons/ or like instead
installs icon CONTRIBUTORS in share/icons/elementary-xfce, it should go in share/elementary-xfce/icons/ or like instead
installs icon LICENSE in share/icons/elementary-xfce, it should go in share/elementary-xfce/icons/ or like instead
installs icon README.md in share/icons/elementary-xfce, it should go in share/elementary-xfce/icons/ or like instead

the diff below 'fixes' it for me, i've taken the list from what i've found as
most regular file types/patterns for icons found in pkglocatedb:

RCS file: /cvs/ports/infrastructure/bin/portcheck,v
diff -u -r1.147 portcheck
--- bin/portcheck       10 Jun 2024 05:10:08 -0000      1.147
+++ bin/portcheck       1 Nov 2024 08:46:46 -0000
@@ -1037,7 +1037,7 @@
                        ;;
                share/icons/default.*)
                        ;;
-               share/icons/*)
+               share/icons/*.@(png|svg|svgz|icon))
                        app=${l#share/icons/}
                        app=${app%%/*}
                        app=${app%%.*}

note that the pattern constructed at line 1022 seems odd (first pipe without braces ?)

share/icons/*/*/*|share/icons/*/@(index.theme|iconrc?(-png)))

oks welcome.