From: Kirill A. Korinsky <kirill@korins.ky>
Subject: Re: audio/beets: update to 2.1.0
To: OpenBSD ports <ports@openbsd.org>, kirill@korins.ky
Date: Fri, 22 Nov 2024 12:29:18 +0100

On Fri, 22 Nov 2024 12:08:01 +0100,
Stuart Henderson <stu@spacehopper.org> wrote:
> 
> On 2024/11/22 11:55, Kirill A. Korinsky wrote:
> > ports@,
> > 
> > I'd like to update audio/beets to 2.1.0.
> > 
> > Here a diff which update beets, adds new optional dependencies which and
> > drops man and tests. Yeah, here no more tests in pypi, and no man, see:
> > https://github.com/beetbox/beets/releases/tag/v2.1.0
> > 
> > Tested on -curren/amd64.
> 
> Missing an RDEP on munkres? (not yet in ports, used in
> beets/autotag/match.py)
>

Are you sure? It has RDEP devel/py-algorithm-munkres

> py-typing-extensions shouldn't be needed since we have py 3.11.
> 
> Not required but I would recommend sorting deps by the order in
> pyproject.toml, it makes it easier to check them.
> 
> README could do with an update, py-acoustid is now an RDEP so users
> don't need telling to install it.

Thanks, here an updated diff:

Index: Makefile
===================================================================
RCS file: /home/cvs/ports/audio/beets/Makefile,v
diff -u -p -r1.64 Makefile
--- Makefile	4 Jun 2024 12:24:44 -0000	1.64
+++ Makefile	22 Nov 2024 11:27:39 -0000
@@ -1,6 +1,6 @@
 COMMENT=	CLI tools to manage music collections
 
-MODPY_EGG_VERSION= 2.0.0
+MODPY_EGG_VERSION= 2.1.0
 DISTNAME=	beets-${MODPY_EGG_VERSION}
 CATEGORIES=	audio
 
@@ -12,37 +12,30 @@ MAINTAINER=	Kirill A. Korinsky <kirill@k
 PERMIT_PACKAGE=	Yes
 
 MODULES=	lang/python
-MODPY_PYBUILD=	setuptools
+MODPY_PYBUILD=	poetry-core
 MODPY_PI=	Yes
 
-RUN_DEPENDS+=	audio/py-discogs-client${MODPY_FLAVOR} \
-		audio/py-last${MODPY_FLAVOR} \
+# no tests in pypi package
+NO_TEST=	Yes
+
+RUN_DEPENDS+=	textproc/py-confuse${MODPY_FLAVOR} \
+		textproc/py-jellyfish${MODPY_FLAVOR} \
 		audio/py-mediafile${MODPY_FLAVOR} \
+		devel/py-algorithm-munkres${MODPY_FLAVOR} \
 		audio/py-musicbrainzngs${MODPY_FLAVOR} \
+		sysutils/py-platformdirs${MODPY_FLAVOR} \
+		textproc/py-yaml${MODPY_FLAVOR} \
+		textproc/py-unidecode${MODPY_FLAVOR} \
+		www/py-beautifulsoup4${MODPY_FLAVOR} \
+		textproc/py-langdetect${MODPY_FLAVOR} \
 		audio/py-mutagen${MODPY_FLAVOR} \
 		graphics/py-Pillow${MODPY_FLAVOR} \
-		devel/py-algorithm-munkres${MODPY_FLAVOR} \
-		devel/py-typing-extensions${MODPY_FLAVOR} \
+		audio/py-acoustid${MODPY_FLAVOR} \
+		audio/py-last${MODPY_FLAVOR} \
+		audio/py-discogs-client${MODPY_FLAVOR} \
 		devel/py-xdg${MODPY_FLAVOR} \
-		textproc/py-confuse${MODPY_FLAVOR} \
-		textproc/py-jellyfish${MODPY_FLAVOR} \
-		textproc/py-langdetect${MODPY_FLAVOR} \
-		textproc/py-unidecode${MODPY_FLAVOR} \
-		textproc/py-yaml${MODPY_FLAVOR} \
-		www/py-beautifulsoup4${MODPY_FLAVOR} \
-		www/py-requests${MODPY_FLAVOR}
-
-post-install:
-	${INSTALL_MAN} ${WRKSRC}/man/beet.1 ${PREFIX}/man/man1
-	${INSTALL_MAN} ${WRKSRC}/man/beetsconfig.5 ${PREFIX}/man/man5
-
-PORTHOME=	${WRKDIR}
-TEST_DEPENDS=	archivers/py-rarfile${MODPY_FLAVOR} \
-		audio/py-mpd2${MODPY_FLAVOR} \
-		devel/py-mock${MODPY_FLAVOR} \
-		devel/py-test-cov${MODPY_FLAVOR} \
-		www/py-flask${MODPY_FLAVOR} \
-		www/py-requests-oauthlib${MODPY_FLAVOR} \
-		www/py-responses${MODPY_FLAVOR}
+		archivers/py-rarfile${MODPY_FLAVOR} \
+		www/py-requests${MODPY_FLAVOR} \
+		www/py-requests-oauthlib${MODPY_FLAVOR}
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /home/cvs/ports/audio/beets/distinfo,v
diff -u -p -r1.24 distinfo
--- distinfo	4 Jun 2024 12:24:44 -0000	1.24
+++ distinfo	22 Nov 2024 10:46:40 -0000
@@ -1,2 +1,2 @@
-SHA256 (beets-2.0.0.tar.gz) = OxFytbw3KeM6bqRon30CNmgr+CjGcZa2omDwOJyx+M8=
-SIZE (beets-2.0.0.tar.gz) = 2194709
+SHA256 (beets-2.1.0.tar.gz) = oKvN+V1fifz0awfdwrW5Lh3Vq+aPTMciLyGv8t/8R4k=
+SIZE (beets-2.1.0.tar.gz) = 478597
Index: patches/patch-test_test_files_py
===================================================================
RCS file: patches/patch-test_test_files_py
diff -N patches/patch-test_test_files_py
--- patches/patch-test_test_files_py	4 Jun 2024 12:24:44 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,18 +0,0 @@
-https://github.com/beetbox/beets/pull/5272
-
-Index: test/test_files.py
---- test/test_files.py.orig
-+++ test/test_files.py
-@@ -88,10 +88,12 @@ class MoveTest(_common.TestCase):
-         self.i.move(operation=MoveOperation.COPY)
-         self.assertExists(self.path)
- 
-+    @unittest.skipUnless(_common.HAVE_REFLINK, "need reflink")
-     def test_reflink_arrives(self):
-         self.i.move(operation=MoveOperation.REFLINK_AUTO)
-         self.assertExists(self.dest)
- 
-+    @unittest.skipUnless(_common.HAVE_REFLINK, "need reflink")
-     def test_reflink_does_not_depart(self):
-         self.i.move(operation=MoveOperation.REFLINK_AUTO)
-         self.assertExists(self.path)
Index: pkg/PLIST
===================================================================
RCS file: /home/cvs/ports/audio/beets/pkg/PLIST,v
diff -u -p -r1.25 PLIST
--- pkg/PLIST	4 Jun 2024 12:24:45 -0000	1.25
+++ pkg/PLIST	22 Nov 2024 10:44:14 -0000
@@ -6,7 +6,6 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/beets-${MODPY_EGG_VERSION}.dist-info/RECORD
 lib/python${MODPY_VERSION}/site-packages/beets-${MODPY_EGG_VERSION}.dist-info/WHEEL
 lib/python${MODPY_VERSION}/site-packages/beets-${MODPY_EGG_VERSION}.dist-info/entry_points.txt
-lib/python${MODPY_VERSION}/site-packages/beets-${MODPY_EGG_VERSION}.dist-info/top_level.txt
 lib/python${MODPY_VERSION}/site-packages/beets/__init__.py
 lib/python${MODPY_VERSION}/site-packages/beets/__main__.py
 ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/beets/${MODPY_PYCACHE}/
@@ -98,10 +97,6 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/beets/util/${MODPY_PYCACHE}artresizer.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/beets/util/${MODPY_PYCACHE}bluelet.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
 lib/python${MODPY_VERSION}/site-packages/beets/util/${MODPY_PYCACHE}bluelet.${MODPY_PYC_MAGIC_TAG}pyc
-lib/python${MODPY_VERSION}/site-packages/beets/util/${MODPY_PYCACHE}confit.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
-lib/python${MODPY_VERSION}/site-packages/beets/util/${MODPY_PYCACHE}confit.${MODPY_PYC_MAGIC_TAG}pyc
-lib/python${MODPY_VERSION}/site-packages/beets/util/${MODPY_PYCACHE}enumeration.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
-lib/python${MODPY_VERSION}/site-packages/beets/util/${MODPY_PYCACHE}enumeration.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/beets/util/${MODPY_PYCACHE}functemplate.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
 lib/python${MODPY_VERSION}/site-packages/beets/util/${MODPY_PYCACHE}functemplate.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/beets/util/${MODPY_PYCACHE}hidden.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
@@ -114,8 +109,6 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/beets/util/${MODPY_PYCACHE}pipeline.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/beets/util/artresizer.py
 lib/python${MODPY_VERSION}/site-packages/beets/util/bluelet.py
-lib/python${MODPY_VERSION}/site-packages/beets/util/confit.py
-lib/python${MODPY_VERSION}/site-packages/beets/util/enumeration.py
 lib/python${MODPY_VERSION}/site-packages/beets/util/functemplate.py
 lib/python${MODPY_VERSION}/site-packages/beets/util/hidden.py
 lib/python${MODPY_VERSION}/site-packages/beets/util/id_extractors.py
@@ -376,6 +369,4 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/beetsplug/web/templates/
 lib/python${MODPY_VERSION}/site-packages/beetsplug/web/templates/index.html
 lib/python${MODPY_VERSION}/site-packages/beetsplug/zero.py
-@man man/man1/beet.1
-@man man/man5/beetsconfig.5
 share/doc/pkg-readmes/${PKGSTEM}
Index: pkg/README
===================================================================
RCS file: /home/cvs/ports/audio/beets/pkg/README,v
diff -u -p -r1.9 README
--- pkg/README	4 Jun 2024 12:24:45 -0000	1.9
+++ pkg/README	22 Nov 2024 11:23:26 -0000
@@ -17,9 +17,6 @@ OAuth token for Discogs; if updating fro
 longer works, you may need to "rm ~/.config/beets/discogs_token.json"
 and login again.
 
-chroma: This plugin is for acoustic fingerprinting. Install py3-acoustid
-and add 'chroma' to the plugins: line.
-
 replaygain: This plugin adds support for ReplayGain, a technique for
 normalizing audio playback levels. It requires dependencies:
 "pkg_add py3-gstreamer1 gstreamer1-plugins-good".


-- 
wbr, Kirill