From: Daniel Jakots <danj@chown.me>
Subject: Re: Update to minio-0.20241107
To: Stuart Henderson <stu@spacehopper.org>
Cc: ports@openbsd.org
Date: Sat, 23 Nov 2024 09:36:17 -0500

On Fri, 22 Nov 2024 17:05:08 +0000, Stuart Henderson
<stu@spacehopper.org> wrote:

> > > If you want to make sure that users do actually change it from the
> > > default, you could check that in the rc.d script,
> > > 
> > > getcap -f /etc/login.conf.d/minio:/etc/login.conf -c setenv minio
> > >  
> > 
> > Indeed a
> > rc_pre() {
> >        getcap -f /etc/login.conf.d/minio:/etc/login.conf -c setenv
> > minio }
> > works as intended, however I'm afraid users will struggle to find
> > out why it doesn't start (we all know how much pkg/README are
> > actually read haha).  
> 
> How about this?
> 
> rc_pre() {
>         if ! getcap -f /etc/login.conf.d/minio:/etc/login.conf \
>             -c setenv minio | grep -q ^=.*MINIO_ROOT_PASSWORD; then
>                 echo "MINIO_ROOT_PASSWORD not set; refer to
> pkg-readme" >&2 return 1
>         fi
> }
>
> "rcctl start minio" will just print "failed", but hopefully people
> know about "rcctl -d start ..."

yeah, works fine, thanks :)

> > /usr/ports/net/minio$ cat server/pkg/README  
> > +-------------------------------------------------------------------------------
> > | Running ${PKGSTEM} on OpenBSD
> > +-------------------------------------------------------------------------------
> > 
> > minio's root access
> > ===================
> > 
> > By default, minio server use minioadmin:minioadmin as the
> > user:password for the root access. The only way to change the
> > default user and/or password is through the MINIO_ROOT_USER and
> > MINIO_ROOT_PASSWORD environment variables. On OpenBSD, this can be
> > achieved through ${SYSCONFDIR}/login.conf.d/minio:  
> 
> That should specifically use /etc not ${SYSCONFDIR}. It is hardcoded
> in libc so in the unlikely event anyone manages to get things to work
> with a modified SYSCONFDIR in the first place, the login.conf.d files
> must be exactly in /etc/login.conf.d.

blame shiori ;)

> Otherwise lgtm.
> 
> > minio:\
> > 	:openfiles-cur=4096:\
> > 	:openfiles-max=8192:\
> > 	:setenv=MINIO_ROOT_USER=root,MINIO_ROOT_PASSWORD=yourstrongpassword:\
> > 	:tc=daemon:  
> 
> > At this point, I believe a diff is too big to be useful so instead,
> > I attached the whole directory (/usr/ports/net$ tar cvzf minio.tgz
> > minio)  
> 
> OK to import minio-old unlinked for now so we can cut the size of
> this :)

done, thanks!

So at this point I think it's ready.

To do the update:
1. commit the server subport update
2. hook up server-old in net/minio/Makefile
3. update the date in faq/current.html
4. commit the faq/current.html

ok?

Cheers,
Daniel