From: Theo Buehler <tb@theobuehler.org>
Subject: Re: NEW: comms/zigpy
To: ports <ports@openbsd.org>
Date: Fri, 29 Nov 2024 19:07:28 +0100

> > comms/py-serial-asyncio - RDEP, async extension for py-serial
> > devel/py-asynctest - TDEP, makes it simpler to test asyncio libraries
> > devel/py-setuptools-git-versioning - BDEP

These three are ok as they are

> > comms/cc2538-bsl - other tool, not directly related, but used to
> >   flash firmware on many of these devices

Here, in DESCR I'd zap "This folder contains a " then capitalize Python
and rewrap, and maybe introduce the abbreviation in the more usual (I
think) form of spelling it out the first time and introducing the
initialism afterward: "System on Chips (SoCs)".

Contrary to the comment in the Makefile, It still appears to need
setuptools-scm. Without them installed, the build looks as follows
(modulo colors):

===>  Building for cc2538-bsl-2.1pl20240918
* Getting build dependencies for wheel...

ERROR Missing dependencies:
	setuptools-scm>=8.0

With all that fixed in some way, I'm ok with importing it, although
tests error out with the following. I tried installing py3-twisted,
but that wasn't enough and the error remained the same. I stopped
trying there.

==================================== ERRORS ====================================
__________________ ERROR collecting tests/test_cc2538-bsl.py ___________________
ImportError while importing test module '/usr/ports/pobj/cc2538-bsl-2.1pl20240918/cc2538-bsl-208cf7a79c6443d3f1c218d8fee1d18096165664/tests/test_cc2538-bsl.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_cc2538-bsl.py:1: in <module>
    from scripttest import TestFileEnvironment
E   ModuleNotFoundError: No module named 'scripttest'
=========================== short test summary info ============================
ERROR tests/test_cc2538-bsl.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.07s ===============================


> > comms/zigpy/py-zigpy - main zigpy module

This again uses this weird initialism first expansion in parentheses
afterward style. Then there's this, so I can't check tests for this and
for py-zigpy-znp.

>> Broken dependency: devel/py-crccheck,python3 non existent (DEPENDS was devel/py-crccheck,python3) in comms/zigpy/py-zigpy,python3

> > comms/zigpy/py-zigpy-znp - module for common TI devices

It reuses COMMENT from py-zigpy, maybe expand znp?