From: David Uhden Collado <david@uhden.dev>
Subject: Re: [wip update] x11/lumina 1.4.0-p1 -> 1.6.2
To: Stuart Henderson <stu@spacehopper.org>
Cc: bryan@bceassociates.com, ports@openbsd.org
Date: Thu, 13 Mar 2025 15:44:00 +0000


> 
>>>> : -lib/qt5/plugins/platformthemes/liblthemeengine.so
>>>> : -lib/qt5/plugins/styles/
>>>> : -lib/qt5/plugins/styles/liblthemeengine-style.so
>>>> ...
>>>> : +usr/
>>>> : +usr/local/
>>>> : +usr/local/lib/
>>>> : +usr/local/lib/qt5/
>>>> : +usr/local/lib/qt5/plugins/
>>>> : +usr/local/lib/qt5/plugins/platformthemes/
>>>> : +@so usr/local/lib/qt5/plugins/platformthemes/liblthemeengine.so
>>>> : +usr/local/lib/qt5/plugins/styles/
>>>> : +@so usr/local/lib/qt5/plugins/styles/liblthemeengine-style.so
>>>>
>>>> that (i.e. /usr/local/usr/local/lib/qt5/plugins) is definitely wrong
>>>
>>> Corrected.
>>
>> That's not corrected, they've just been removed from the PLIST
>> rather than installed in the correct location.
>>
>>>> : +etc/
>>>> that shouldn't be in the package
>>>
>>> Corrected.
>>
>> also just removed from PLIST, it needs either rmdir in post-install
>> or @comment in PLIST
>>
>>>> : +++ ports/x11/lumina/pkg/DESCR    8 Mar 2025 01:21:42 -0000
>>>> : @@ -1 +1,6 @@
>>>> : -Lumina-DE is a lightweight, BSD licensed desktop environment.
>>>> : +The Lumina Desktop Environment is a lightweight system interface 
>>>> that is
>>>> : +designed for use on any Unix-like operating system. It takes a 
>>>> plugin-based
>>>> : +approach, allowing the entire interface to be assembled/arranged 
>>>> by each
>>>> : +individual user as desired, with a system-wide default layout 
>>>> which can be
>>>> : +setup by the system administrator. This allows every system (or 
>>>> user session)
>>>> : +to be designed to maximize the individual user's productivity.
>>>>
>>>> stray whitespace at the end of each line except the last
>>>
>>> I don't see any stray whitespace at the end of the last line.
>>
>> Each line *except* the last
>>
> 
> Thank you for your help!
> 
> I have attached a new diff that I hope addresses all the issues you 
> mentioned. Additionally, I have included a patch to fix a problem where 
> the desktop environment was searching for files in "/share/" instead of 
> "${PREFIX}/share/", causing it to fail to run.
> 
> I appreciate your time and feedback.
> 
> Best regards,
> David.

I have tested this version of the Lumina desktop environment on amd64 
and encountered two issues that I am unsure how to patch:

1. The desktop environment searches for the "lumina-desktop" directory 
in "/share/" instead of "/usr/local/share/", as it should.

2. When opening the terminal, the text editor mistakenly opens a file 
named "xterm" instead of launching the terminal itself.

Everything else appears to work fine.