From: Simon Howard <fraggle@soulsphere.org>
Subject: Re: NEW: games/sopwith
To: ports@openbsd.org, Ryan Freeman <ryan@slipgate.org>
Date: Fri, 28 Mar 2025 20:38:11 -0400

Hi folks, nice to see the new port is now in CVS. I just noticed a couple
of nitpicky things about the COMMENT line I hadn't noticed when reviewing
it:

FIrstly SDL Sopwith is not a "clone" of the original but is directly
descended from the original source.  NetHack isn't a "clone" of Hack for
example, nor OpenBSD a "clone" of 4.4BSD :)

Secondly there's a typo - "dogfighing" should be spelled dogfighting.

Attaching patch with proposed change.

On Fri, Mar 28, 2025, 8:34 AM Anthony J. Bentley <anthony@anjbe.name> wrote:

> Ryan Freeman writes:
> > On Thu, Mar 27, 2025 at 04:36:02AM -0600, Anthony J. Bentley wrote:
> > > Ryan Freeman writes:
> > > > Attached is a new port of SDL Sopwith.
> > > >
> > > > From the website: https://fragglet.github.io/sdl-sopwith/
> > > >
> > > > SDL Sopwith is a port of the classic biplane shoot 'em-up "Sopwith"
> to ru
> > n
> > > > on modern computers and operating systems. It is named "SDL Sopwith"
> as i
> > t
> > > > uses the LibSDL cross-platform library.
> > > >
> > > > Simon (author, CC'd) reached out to me last week inquiring about
> having a
> > > > port made and I was happy to oblige.  I'm not very good at this
> game, but
> > > > it works good here on -current amd64, and Simon successfully tested
> it
> > > > himself as well.
> > >
> > > PLIST can be trimmed a bit with 'make update-plist'. And if the
> pkgname is
> > > sdl-sopwith, can we put the port in games/sdl-sopwith as well?
> > >
> > > Attached port makes these trivial changes, and is ok bentley@ (or I
> can
> > > import with another ok)
> >
> > No objection from me on games/sdl-sopwith; looks like I followed
> > how the debian package is named when I made the directory, but
> > never gave it a PKGNAME.
> >
> > Thanks for the update-plist catch!  Does the initial PLIST creation
> > usually include superfluous directory paths?
>
> update-plist strips directories that already exist in dependencies.
> You probably generated the plist before adding desktop-file-utils
> and gtk+4,-guic to RUN_DEPENDS. Which is only natural, since it's
> rare to add those dependencies *before* seeing icons and desktop
> files in the plist...
>