From: "Igor Zornik" Subject: Re: [UPDATE] sysutils/lf r32 -> r34 To: "Alvar Penning" , Cc: Date: Wed, 16 Apr 2025 19:51:33 +0200 On Tue Apr 15, 2025 at 9:25 PM CEST, Alvar Penning wrote: >> New version of lf available. I can still build it and browse with it on >> latest snapshot amd64. Diff below. > > Thanks for your patch. I have just created almost the same and it works > fine for me. > > However, would you mind setting MODGO_LDFLAGS as follows, allowing "lf > -version" to work. >> +MODGO_LDFLAGS = -X main.gVersion=${R} > > Best, > Alvar Hi! Thanks for the info. It seems their build process really does set this variable based on the git tag (that would be "r${R}" as opposed to just "${R}. No, I wouldn't mind setting this flag, but there is not much point to this discussion without any feedback from the maintainer. I wouldn't get my hopes up too much considering it's been over two months since the original submission (more so for R33). Anyway, here's the amended diff. Rechecked with yesterday's amd64 snap. Index: Makefile =================================================================== RCS file: /cvs/ports/sysutils/lf/Makefile,v retrieving revision 1.7 diff -u -p -u -p -r1.7 Makefile --- Makefile 21 Aug 2024 06:30:27 -0000 1.7 +++ Makefile 16 Apr 2025 17:45:08 -0000 @@ -1,9 +1,9 @@ COMMENT = terminal file manager inspired by ranger written in Go MODGO_MODNAME = github.com/gokcehan/lf -MODGO_VERSION = v0.0.0-20240331195418-d26eb0108a63 +MODGO_VERSION = v0.0.0-20250209115006-c25647d364e7 -R = 32 +R = 34 DISTNAME = lf-${R} CATEGORIES = sysutils @@ -16,6 +16,8 @@ MAINTAINER = Chang, Chu-Kuan